GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117376: Partial implementation of deferred reference counting by colesbury · Pull Request #117696 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Apr 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This marks objects as using deferred refrence counting using the
ob_gc_bits field in the free-threaded build and collects those objects
during GC.

  • Issue: Implement deferred reference counting in free-threaded builds #117376

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury colesbury added skip news topic-free-threading labels Apr 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 9, 2024
Implement deferred reference counting in free-threaded builds #117376
Closed
@colesbury

colesbury commented Apr 9, 2024

Copy link
Copy Markdown
Contributor Author

cc @Fidget-Spinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner
Fidget-Spinner approved these changes Apr 9, 2024
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a few questions/thoughts of my own.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Objects/moduleobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/typeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting merge label Apr 9, 2024
Fidget-Spinner
Fidget-Spinner reviewed Apr 9, 2024
View reviewed changes
Comment thread Objects/funcobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@colesbury colesbury added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 10, 2024
@bedevere-bot

bedevere-bot commented Apr 10, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 6e683db 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 10, 2024
Fidget-Spinner
Fidget-Spinner reviewed Apr 10, 2024
View reviewed changes
Comment thread Python/gc_free_threading.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
colesbury added 2 commits April 11, 2024 19:03
@colesbury
pythongh-117376: Partial implementation deferred reference counting
206571b 
This marks objects as using deferred refrence counting using the
`ob_gc_bits` field in the free-threaded build and collects those objects
during GC.
@colesbury
Remove unused function
30fc873
@colesbury
colesbury force-pushed the gh-117376-deferred-rc branch from 1622045 to 30fc873 Compare April 11, 2024 19:08
@colesbury
Simplify module___init___impl
f8add0e
@colesbury
colesbury marked this pull request as ready for review April 11, 2024 19:34
@colesbury
colesbury requested review from ericsnowcurrently and markshannon as code owners April 11, 2024 19:34
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting merge labels Apr 11, 2024
@colesbury colesbury added 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section and removed awaiting core review labels Apr 11, 2024
@bedevere-bot

bedevere-bot commented Apr 11, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit f8add0e 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 11, 2024
@colesbury
Merge branch 'main' into pythongh-117376-deferred-rc
1d2d548
@colesbury

colesbury commented Apr 12, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot nogil
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Apr 12, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 1d2d548 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • AMD64 Ubuntu NoGIL Refleaks PR
  • x86-64 MacOS Intel NoGIL PR
  • AMD64 Ubuntu NoGIL PR
  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • ARM64 MacOS M1 NoGIL PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
Remove extra whitespace
7034171
@colesbury
colesbury enabled auto-merge (squash) April 12, 2024 17:32
@colesbury
colesbury merged commit 4ad8f09 into python:main Apr 12, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@colesbury @diegorusso
pythongh-117376: Partial implementation of deferred reference counting (
70dc4b9 
python#117696)

This marks objects as using deferred refrence counting using the
`ob_gc_bits` field in the free-threaded build and collects those objects
during GC.
@colesbury
colesbury deleted the gh-117376-deferred-rc branch July 16, 2024 19:58
@colesbury colesbury mentioned this pull request Jul 31, 2024
Crash on deallocator of type 'time.struct_time' during finalizing for free-threaded Python #122527
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@colesbury @bedevere-bot @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.