GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-112536: Define `_Py_THREAD_SANITIZER` on GCC when TSan is enabled (GH-117702) by miss-islington · Pull Request #117713 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Apr 10, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The __has_feature(thread_sanitizer) is a Clang-ism. Although new
versions of GCC implement __has_feature, the defined(__has_feature)
check still fails on GCC so we don't use that code path.
(cherry picked from commit 79eec66)

Co-authored-by: Sam Gross [email protected]

  • Issue: Add support for thread sanitizer (TSAN) via --with-thread-sanitizer #112536

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@colesbury @miss-islington
pythongh-112536: Define _Py_THREAD_SANITIZER on GCC when TSan is en…
8206a1e
…abled (pythonGH-117702)

The `__has_feature(thread_sanitizer)` is a Clang-ism. Although new
versions of GCC implement `__has_feature`, the `defined(__has_feature)`
check still fails on GCC so we don't use that code path.
(cherry picked from commit 79eec66)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Apr 10, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 10, 2024
gh-112536: Define _Py_THREAD_SANITIZER on GCC when TSan is enabled #117702
Merged
@bedevere-app bedevere-app Bot added the skip news label Apr 10, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 10, 2024
Add support for thread sanitizer (TSAN) via --with-thread-sanitizer #112536
Closed
@colesbury
colesbury enabled auto-merge (squash) April 10, 2024 14:25
@colesbury
colesbury merged commit 04d0796 into python:3.12 Apr 10, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Apr 10, 2024
@miss-islington
miss-islington deleted the backport-79eec66-3.12 branch January 2, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.