GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112536: Define `_Py_THREAD_SANITIZER` on GCC when TSan is enabled by colesbury · Pull Request #117702 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Apr 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The __has_feature(thread_sanitizer) is a Clang-ism. Although new versions of GCC implement __has_feature, the defined(__has_feature) check still fails on GCC so we don't use that code path.

  • Issue: Add support for thread sanitizer (TSAN) via --with-thread-sanitizer #112536

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@colesbury
pythongh-112536: Define _Py_THREAD_SANITIZER on GCC when TSan is en…
fcb9681
…abled

The `__has_feature(thread_sanitizer)` is a Clang-ism. Although new
versions of GCC implement `__has_feature`, the `defined(__has_feature)`
check still fails on GCC so we don't use that code path.
@colesbury colesbury added the skip news label Apr 9, 2024
@colesbury
colesbury requested review from corona10 and pitrou April 9, 2024 21:23
@bedevere-app bedevere-app Bot mentioned this pull request Apr 9, 2024
Add support for thread sanitizer (TSAN) via --with-thread-sanitizer #112536
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 9, 2024
@pitrou pitrou added the needs backport to 3.12 only security fixes label Apr 10, 2024
pitrou
pitrou reviewed Apr 10, 2024
View reviewed changes
Comment thread Include/pyport.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

corona10
corona10 approved these changes Apr 10, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 10, 2024
@colesbury
colesbury merged commit 79eec66 into python:main Apr 10, 2024
@colesbury
colesbury deleted the gh-112536-gcc-tsan branch April 10, 2024 14:20
@miss-islington-app

miss-islington-app Bot commented Apr 10, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 10, 2024
@bedevere-app

bedevere-app Bot commented Apr 10, 2024

Copy link
Copy Markdown

GH-117713 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Apr 10, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 10, 2024
@colesbury @miss-islington
pythongh-112536: Define _Py_THREAD_SANITIZER on GCC when TSan is en…
8206a1e
…abled (pythonGH-117702)

The `__has_feature(thread_sanitizer)` is a Clang-ism. Although new
versions of GCC implement `__has_feature`, the `defined(__has_feature)`
check still fails on GCC so we don't use that code path.
(cherry picked from commit 79eec66)

Co-authored-by: Sam Gross <[email protected]>
colesbury added a commit that referenced this pull request Apr 10, 2024
@miss-islington @colesbury
[3.12] gh-112536: Define _Py_THREAD_SANITIZER on GCC when TSan is e…
04d0796
…nabled (GH-117702) (#117713)

gh-112536: Define `_Py_THREAD_SANITIZER` on GCC when TSan is enabled (GH-117702)

The `__has_feature(thread_sanitizer)` is a Clang-ism. Although new
versions of GCC implement `__has_feature`, the `defined(__has_feature)`
check still fails on GCC so we don't use that code path.
(cherry picked from commit 79eec66)

Co-authored-by: Sam Gross <[email protected]>
@colesbury colesbury mentioned this pull request Apr 11, 2024
Disable GIL by default in free-threaded build #116749
Closed
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@colesbury @diegorusso
pythongh-112536: Define _Py_THREAD_SANITIZER on GCC when TSan is en…
f7aafbb
…abled (python#117702)

The `__has_feature(thread_sanitizer)` is a Clang-ism. Although new
versions of GCC implement `__has_feature`, the `defined(__has_feature)`
check still fails on GCC so we don't use that code path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou left review comments
@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@colesbury @pitrou @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.