GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix version directive indents by hugovk · Pull Request #117719 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Apr 10, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We've added colour to the version change directives: python/python-docs-theme#185

This has made it more obvious when some are misaligned to the thing they relate to. There will be more but this PR fixes some.

image

https://docs.python.org/3.13/library/decimal.html#constants

image

https://docs.python.org/3.13/library/ipaddress.html#ipaddress.IPv6Address

image

https://docs.python.org/3.13/library/ssl.html#ssl.SSLContext.wrap_socket

image

https://docs.python.org/3.13/library/urllib.request.html#urllib.request.urlopen

📚 Documentation preview 📚: https://cpython-previews--117719.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Fix version directive indents
f27cb0f
@hugovk
hugovk requested a review from rhettinger as a code owner April 10, 2024 17:13
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting core review labels Apr 10, 2024
@hugovk hugovk added skip issue needs backport to 3.12 only security fixes labels Apr 10, 2024
@hugovk
hugovk merged commit 94e9c35 into python:main Apr 12, 2024
@hugovk
hugovk deleted the docs-directive-indent branch April 12, 2024 10:30
@miss-islington-app

miss-islington-app Bot commented Apr 12, 2024

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Apr 12, 2024
@miss-islington-app

miss-islington-app Bot commented Apr 12, 2024

Copy link
Copy Markdown

Sorry, @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 94e9c35cd0f2898693bb96eb1579fe0329648fa2 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned hugovk Apr 12, 2024
@bedevere-app

bedevere-app Bot commented Apr 12, 2024

Copy link
Copy Markdown

GH-117810 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Apr 12, 2024
hugovk added a commit to hugovk/cpython that referenced this pull request Apr 12, 2024
@hugovk
[3.12] Fix version directive indents (pythonGH-117719)
0af70ed 
(cherry picked from commit 94e9c35)

Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Apr 12, 2024
@hugovk
[3.12] Fix version directive indents (GH-117719) (#117810)
aeb4ac7
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@hugovk @diegorusso
Fix version directive indents (python#117719)
22b3161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.