GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117688: Fix deadlock in test_no_stale_references with GIL disabled by colesbury · Pull Request #117720 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Apr 10, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Check my_object_collected.wait() in a loop to give the main thread a
chance to merge the reference count fields. Additionally, call
my_object_collected.set() in a background thread to avoid deadlocking
when the destructor is called asynchronously via the eval breaker
within the body of of my_object_collected.wait().

  • Issue: ThreadPoolExecutorTest.test_no_stale_references may hang with GIL disabled #117688

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-117688: Fix deadlock in test_no_stale_references with GIL di…
1ce167b 
…sabled
@colesbury colesbury added tests Tests in the Lib/test dir topic-free-threading labels Apr 10, 2024
@colesbury
colesbury requested a review from corona10 April 10, 2024 18:06
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 10, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 10, 2024
ThreadPoolExecutorTest.test_no_stale_references may hang with GIL disabled #117688
Closed
@colesbury colesbury added the skip news label Apr 10, 2024
@corona10

corona10 commented Apr 11, 2024

Copy link
Copy Markdown
Member

Oh, I will take a look at it by tomorrow :) I need to read the details.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 self-assigned this Apr 11, 2024
@colesbury

colesbury commented Apr 11, 2024

Copy link
Copy Markdown
Contributor Author

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury colesbury mentioned this pull request Apr 11, 2024
Disable GIL by default in free-threaded build #116749
Closed
corona10
corona10 approved these changes Apr 13, 2024
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
It is a complicated situation, and I can not find a better solution.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 13, 2024
@colesbury
colesbury merged commit 520cf21 into python:main Apr 15, 2024
@colesbury
colesbury deleted the gh-117688-test_no_stale_references branch April 15, 2024 16:54
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 15, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@colesbury @diegorusso
pythongh-117688: Fix deadlock in test_no_stale_references with GIL di…
d203263 
…sabled (python#117720)

Check `my_object_collected.wait()` in a loop to give the main thread a
chance to merge the reference count fields. Additionally, call
`my_object_collected.set()` in a background thread to avoid deadlocking
when the destructor is called asynchronously via the eval breaker
within the body of of `my_object_collected.wait()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@corona10 corona10

Labels

skip news tests Tests in the Lib/test dir topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@colesbury @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.