GeezerVison is showing github.com — GH-117727: Speed up `pathlib.Path.iterdir()` by using `os.scandir()` by barneygale · Pull Request #117728 · python/cpython
Conversation
barneygale
commented
Apr 10, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Replace use of os.listdir() with os.scandir(). Forgo setting _drv, _root and _tail_cached, as these usually aren't needed. Use os.DirEntry.path to set _str.
Timing:
$ ./python -m timeit -s "from pathlib import Path; p = Path('Lib')" "list(p.iterdir())"
1000 loops, best of 5: 303 usec per loop # before
1000 loops, best of 5: 257 usec per loop # after
# --> 1.18x faster
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…ir()`
Replace use of `os.listdir()` with `os.scandir()`. Forgo setting `_drv`,
`_root` and `_tail_cached`, as these usually aren't needed. Use
`os.DirEntry.path` to set `_str`.
Uh oh!
There was an error while loading. Please reload this page.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ir()` (python#117728)
Replace use of `os.listdir()` with `os.scandir()`. Forgo setting `_drv`,
`_root` and `_tail_cached`, as these usually aren't needed. Use
`os.DirEntry.path` to set `_str`.
Reviewers
eryksun
eryksun left review comments
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.