GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117764: Add signatures for some functions in the sys module by serhiy-storchaka · Pull Request #117770 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Apr 11, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add more signatures for builtin functions and methods #117764

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-117764: Add signatures for some functions in the sys module
162f4b8
@serhiy-storchaka serhiy-storchaka added the skip news label Apr 11, 2024
@serhiy-storchaka
serhiy-storchaka requested a review from ericsnowcurrently as a code owner April 11, 2024 18:30
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 11, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 11, 2024
Add more signatures for builtin functions and methods #117764
Closed
erlend-aasland
erlend-aasland reviewed Apr 11, 2024
View reviewed changes
Comment thread Python/sysmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Apr 12, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 12, 2024
@serhiy-storchaka
Use Argument Clinic if possible.
679f067
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) April 12, 2024 08:45
@serhiy-storchaka
serhiy-storchaka merged commit 2638c28 into python:main Apr 12, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 12, 2024
@erlend-aasland

erlend-aasland commented Apr 12, 2024

Copy link
Copy Markdown
Contributor

Even better with 679f067 🚀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@serhiy-storchaka @diegorusso
pythongh-117764: Add signatures for some functions in the sys module (p…
750daf9 
…ythonGH-117770)

Use Argument Clinic if possible.
@serhiy-storchaka
serhiy-storchaka deleted the sys-signatures branch July 1, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.