GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117764: Add signatures for functions in the faulthandler module by serhiy-storchaka · Pull Request #117771 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Apr 11, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add more signatures for builtin functions and methods #117764

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-117764: Add signatures for functions in the faulthandler module
e628d6f
@serhiy-storchaka serhiy-storchaka added the skip news label Apr 11, 2024
@serhiy-storchaka
serhiy-storchaka requested a review from vstinner April 11, 2024 18:38
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 11, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 11, 2024
Add more signatures for builtin functions and methods #117764
Closed
erlend-aasland
erlend-aasland approved these changes Apr 11, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 11, 2024
@serhiy-storchaka
Add $module and fix some errors.
b6ff519
serhiy-storchaka
serhiy-storchaka commented Apr 12, 2024
View reviewed changes
Comment thread Modules/faulthandler.c
_PyCFunction_CAST(faulthandler_unregister_py), METH_VARARGS|METH_KEYWORDS,
PyDoc_STR("unregister(signum): unregister the handler of the signal "
"'signum' registered by register()")},
_PyCFunction_CAST(faulthandler_unregister_py), METH_VARARGS,

@serhiy-storchaka serhiy-storchaka Apr 12, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a bug. The function does not support keyword arguments. It was an undefined behavior.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
erlend-aasland
erlend-aasland approved these changes Apr 12, 2024
View reviewed changes
@serhiy-storchaka
serhiy-storchaka merged commit 245e426 into python:main Apr 12, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 12, 2024
@serhiy-storchaka
serhiy-storchaka deleted the faulthandler-signatures branch April 12, 2024 10:14
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 only security fixes label Apr 12, 2024
@miss-islington-app

miss-islington-app Bot commented Apr 12, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 12, 2024
@serhiy-storchaka @miss-islington
pythongh-117764: Add signatures for functions in the faulthandler mod…
837ea6a 
…ule (pythonGH-117771)

(cherry picked from commit 245e426)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Apr 12, 2024

Copy link
Copy Markdown

GH-117806 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Apr 12, 2024
serhiy-storchaka added a commit that referenced this pull request Apr 12, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-117764: Add signatures for functions in the faulthandler mo…
0b11f0e 
…dule (GH-117771) (GH-117806)

(cherry picked from commit 245e426)

Co-authored-by: Serhiy Storchaka <[email protected]>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@serhiy-storchaka @diegorusso
pythongh-117764: Add signatures for functions in the faulthandler mod…
c3e1ff8 
…ule (pythonGH-117771)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.