GeezerVison is showing github.com — gh-117755: Skip test_io.test_constructor() on s390x by vstinner · Pull Request #117801 · python/cpython
Conversation
vstinner
commented
Apr 12, 2024
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
The test allocates 9 223 372 036 854 775 807 bytes (0x7fffffffffffffff) and mimalloc fails with a division by zero on s390x.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The test allocates 9 223 372 036 854 775 807 bytes
(0x7fffffffffffffff) and mimalloc fails with a division by zero on
s390x.
|
This is a bug in mimalloc. We already worked around a similar (but different) bug in test_decimal by skipping the test: see issue gh-114331. I will try investigate the mimalloc issue later, but I prefer to skip the test for now to unblock my colleague @befeleme with Python 3.13 alpha6.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
...to unblock my colleague @befeleme with Python 3.13 alpha6.
For clarification, we (me and @befeleme) are not blocked on this. The freethreding build in Fedora is disabled on s390x and we can keep it that way for now.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
For clarification, we (me and @befeleme) are not blocked on this. The freethreding build in Fedora is disabled on s390x and we can keep it that way for now.
As the s390x maintainer in Python, I would prefer that you test it to discover real bugs like these ones :-)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
This change is a workaround.
I wrote a fix for the root issue in mimalloc: PR gh-117809.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️
Hi! The buildbot AMD64 FreeBSD14 3.x has failed when building commit a9107fe.
What do you need to do:
- Don't panic.
- Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
- Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1232/builds/1984) and take a look at the build logs.
- Check if the failure is related to this commit (a9107fe) or if it is a false positive.
- If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.
You can take a look at the buildbot page here:
https://buildbot.python.org/all/#builders/1232/builds/1984
Summary of the results of the build (if available):
==
Click to see traceback logs
Traceback (most recent call last):
File "<frozen getpath>", line 352, in <module>
ValueError: embedded null byte
Warning -- Uncaught thread exception: InterpreterError
Exception in thread Thread-57 (task):
RuntimeError: error evaluating path
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/threading.py", line 1039, in _bootstrap_inner
self.run()
~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/threading.py", line 990, in run
self._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/test_interpreters/test_stress.py", line 29, in task
interp = interpreters.create()
~~~~~~~~~~~~~~~~~~~^^
File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/support/interpreters/__init__.py", line 76, in create
id = _interpreters.create(reqrefs=True)
~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
interpreters.InterpreterError: interpreter creation failed
k
Traceback (most recent call last):
File "<frozen getpath>", line 462, in <module>
ValueError: embedded null byte
Warning -- Uncaught thread exception: InterpreterError
Exception in thread Thread-100 (task):
RuntimeError: error evaluating path
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
)
The test allocates 9 223 372 036 854 775 807 bytes
(0x7fffffffffffffff) and mimalloc fails with a division by zero on
s390x.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|