GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117764: Add more tests for signatures of builtins by serhiy-storchaka · Pull Request #117816 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Apr 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Test signatures of all public builtins and methods of builtin classes in modules builtins, types, sys, and several other modules (either included in the list of standard builtin modules sys.builtin_module_names, or providing a public interface for such modules).

Most builtins should have supported signatures, with few known exceptions. When more builtins will be converted to Argument Clinic or support of new signatures be implemented, they will be removed from the exception lists.

  • Issue: Add more signatures for builtin functions and methods #117764

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka
pythongh-117764: Add more tests for signatures of builtins
b696af4
Test signatures of all public builtins and methods of builtin classes
in modules builtins, types, sys, and several other modules (either
included in the list of standard builtin modules sys.builtin_module_names,
or providing a public interface for such modules).

Most builtins should have supported signatures, with few known exceptions.
When more builtins will be converted to Argument Clinic or support of
new signatures be implemented, they will be removed from the exception
lists.
@serhiy-storchaka serhiy-storchaka added the skip news label Apr 12, 2024
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Apr 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 12, 2024
Add more signatures for builtin functions and methods #117764
Closed
erlend-aasland
erlend-aasland approved these changes Apr 12, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 12, 2024
serhiy-storchaka added 2 commits April 12, 2024 16:34
@serhiy-storchaka
Fix tests on Windows and macOS.
a73d99c
@serhiy-storchaka
Fix the previous fix on Linux.
f8e13c0
@serhiy-storchaka

serhiy-storchaka commented Apr 12, 2024

Copy link
Copy Markdown
Member Author

!buildbot bsd
!buildbot wasm

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Apr 12, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit f8e13c0 🤖

The command will test the builders whose names match following regular expression: bsd

The builders matched are:

  • AMD64 FreeBSD PR
  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD14 PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka

serhiy-storchaka commented Apr 12, 2024

Copy link
Copy Markdown
Member Author

!buildbot wasm

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Apr 12, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit f8e13c0 🤖

The command will test the builders whose names match following regular expression: wasm

The builders matched are:

  • wasm32 WASI 8Core PR
  • wasm32-wasi Non-Debug PR
  • wasm32-wasi PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
Fix tests on wasm.
5fe8494
@serhiy-storchaka

serhiy-storchaka commented Apr 12, 2024

Copy link
Copy Markdown
Member Author

!buildbot "wasm32 WASI 8Core"

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Apr 12, 2024

Copy link
Copy Markdown

The regex '"wasm32 WASI 8Core"' did not match any buildbot builder. Is the requested builder in the list of stable builders?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka

serhiy-storchaka commented Apr 12, 2024

Copy link
Copy Markdown
Member Author

!buildbot wasm32 WASI 8Core

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Apr 12, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 5fe8494 🤖

The command will test the builders whose names match following regular expression: wasm32 WASI 8Core

The builders matched are:

  • wasm32 WASI 8Core PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
Final fix.
14a6ea2
@serhiy-storchaka

serhiy-storchaka commented Apr 12, 2024

Copy link
Copy Markdown
Member Author

!buildbot wasm32 WASI 8Core

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Apr 12, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 14a6ea2 🤖

The command will test the builders whose names match following regular expression: wasm32 WASI 8Core

The builders matched are:

  • wasm32 WASI 8Core PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) April 12, 2024 14:52
@serhiy-storchaka
serhiy-storchaka disabled auto-merge April 12, 2024 14:53
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) April 12, 2024 14:53
@serhiy-storchaka
serhiy-storchaka merged commit c50cb6d into python:main Apr 12, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 12, 2024
@serhiy-storchaka
serhiy-storchaka deleted the test-builtin-signatures branch April 12, 2024 14:55
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@serhiy-storchaka @diegorusso
pythongh-117764: Add more tests for signatures of builtins (pythonGH-…
74a9e41
…117816)

Test signatures of all public builtins and methods of builtin classes
in modules builtins, types, sys, and several other modules (either
included in the list of standard builtin modules sys.builtin_module_names,
or providing a public interface for such modules).

Most builtins should have supported signatures, with few known exceptions.
When more builtins will be converted to Argument Clinic or support of
new signatures be implemented, they will be removed from the exception
lists.
@ZeroIntensity ZeroIntensity mentioned this pull request Jul 11, 2025
Failure when running test_inspect locally #136549
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @bedevere-bot @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.