GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-96398: Fix mpicc check in configure.ac by erlend-aasland · Pull Request #117857 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 13, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: configure.ac: using $CC to check compiler names may result in erroneous judgements #96398

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-96398: Fix mpicc check in configure.ac
15ffdac
@erlend-aasland
erlend-aasland requested a review from corona10 as a code owner April 13, 2024 20:55
@erlend-aasland erlend-aasland added the skip news label Apr 13, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 13, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 13, 2024
configure.ac: using $CC to check compiler names may result in erroneous judgements #96398
Closed
@erlend-aasland
erlend-aasland enabled auto-merge (squash) April 13, 2024 20:55
@erlend-aasland erlend-aasland mentioned this pull request Apr 13, 2024
gh-96398: Improve accuracy of compiler checks in configure.ac #117815
Merged
@erlend-aasland
erlend-aasland merged commit 3095d02 into python:main Apr 13, 2024
@erlend-aasland
erlend-aasland deleted the autoconf/fix-mpicc-check branch April 13, 2024 21:22
@bedevere-app bedevere-app Bot removed the awaiting core review label Apr 13, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-96398: Fix mpicc check in configure.ac (python#117857)
c43ad26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.