GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112069: Make setiter_iternext to be thread-safe by corona10 · Pull Request #117935 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Apr 16, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Make set thread-safe in --disable-gil builds #112069

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
pythongh-112069: Make setiter_iternext to be thread-safe
ab18f4e
@corona10 corona10 added the topic-free-threading label Apr 16, 2024
@corona10
corona10 requested a review from colesbury April 16, 2024 15:44
@corona10
corona10 requested a review from rhettinger as a code owner April 16, 2024 15:44
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 16, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 16, 2024
Make set thread-safe in --disable-gil builds #112069
Closed
3 tasks done
@corona10 corona10 added the skip news label Apr 16, 2024
colesbury
colesbury approved these changes Apr 16, 2024
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One minor comment below

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Objects/setobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 16, 2024
@corona10
Address code review
67a9efc
@corona10
corona10 enabled auto-merge (squash) April 16, 2024 15:58
@corona10
corona10 merged commit a734fd5 into python:main Apr 16, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 16, 2024
@corona10
corona10 deleted the gh-112069-set-iter branch April 16, 2024 17:15
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@corona10 @diegorusso
pythongh-112069: Make setiter_iternext to be thread-safe (pythongh-11…
854fe3e 
…7935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corona10 @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.