GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117953: Add Internal struct _Py_ext_module_loader_info by ericsnowcurrently · Pull Request #118194 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Apr 23, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I've pulled this out of #118116.

This helps with a later change that splits up _PyImport_LoadDynamicModuleWithSpec().

  • Issue: Single-Phase Init Extension Module Init Functions Still Run in Isolated Interpreters #117953

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently ericsnowcurrently added the skip news label Apr 23, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 23, 2024
Single-Phase Init Extension Module Init Functions Still Run in Isolated Interpreters #117953
Closed
ericsnowcurrently added 9 commits April 24, 2024 10:51
@ericsnowcurrently
Add struct _Py_ext_module_loader_info.
02eddb9
@ericsnowcurrently
Pass info to _PyImport_LoadDynamicModuleWithSpec().
c9600ba
@ericsnowcurrently
Calculate path_bytes ahead of time.
5d927b7
@ericsnowcurrently
_Py_ext_module_loader_info_from_spec() -> _Py_ext_module_loader_info_…
427280f 
…init_from_spec()
@ericsnowcurrently
Add info.newcontext.
d5f97e7
@ericsnowcurrently
path -> filename
5d951b3
@ericsnowcurrently
Factor out _Py_ext_module_loader_info_init().
481bf5d
@ericsnowcurrently
Add _Py_ext_module_loader_info.path.
425c5e0
@ericsnowcurrently
Pass loader info to import_find_extension().
2a9b621
@ericsnowcurrently
ericsnowcurrently force-pushed the add-loader-info-struct branch from d2d8b88 to 2a9b621 Compare April 24, 2024 16:52
@ericsnowcurrently
ericsnowcurrently marked this pull request as ready for review April 24, 2024 16:52
@ericsnowcurrently
ericsnowcurrently requested review from brettcannon, kumaraditya303, ncoghlan and warsaw as code owners April 24, 2024 16:52
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 24, 2024
@ericsnowcurrently
ericsnowcurrently removed request for brettcannon, kumaraditya303, ncoghlan and warsaw April 24, 2024 16:52
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) April 24, 2024 17:30
@ericsnowcurrently
ericsnowcurrently disabled auto-merge April 24, 2024 17:31
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) April 24, 2024 17:33
@ericsnowcurrently
ericsnowcurrently merged commit 5865fa5 into python:main Apr 24, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Apr 24, 2024
@ericsnowcurrently
ericsnowcurrently deleted the add-loader-info-struct branch April 24, 2024 18:25
@ericsnowcurrently

ericsnowcurrently commented Apr 24, 2024

Copy link
Copy Markdown
Member Author

Looks like a refleak slipped through with this PR. I'm working on a fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 24, 2024
gh-117953: Fix Refleaks Introduced by gh-118194 #118250
Merged
ericsnowcurrently added a commit that referenced this pull request Apr 24, 2024
@ericsnowcurrently
gh-117953: Fix Refleaks Introduced by gh-118194 (gh-118250)
85ec1c2 
A couple of refleaks slipped through in gh-118194. This takes care of them.

(AKA _Py_ext_module_loader_info_init() does not steal references.)
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Apr 24, 2024
@ericsnowcurrently
pythongh-117953: Fix Refleaks Introduced by pythongh-118194 (pythongh…
9508b74 
…-118250)

A couple of refleaks slipped through in pythongh-118194. This takes care of them.

(AKA _Py_ext_module_loader_info_init() does not steal references.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.