GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118216: Don't consider dotted `__future__` imports by thatbirdguythatuknownot · Pull Request #118267 · python/cpython

Conversation

@thatbirdguythatuknownot

@thatbirdguythatuknownot thatbirdguythatuknownot commented Apr 25, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add checking for the number of dots before the module name alongside __future__ name checks in Python/future.c and Python/compile.c. Basically makes a __future__ import only be considered one when no dots are present before the module name.

  • Issue: __future__ imports allow dots before them #118216

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thatbirdguythatuknownot
thatbirdguythatuknownot requested review from iritkatriel and markshannon as code owners April 25, 2024 06:17
@bedevere-app bedevere-app Bot mentioned this pull request Apr 25, 2024
__future__ imports allow dots before them #118216
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Apr 25, 2024
@thatbirdguythatuknownot
thatbirdguythatuknownot force-pushed the patch-33 branch from f0caedc to 9adb811 Compare April 25, 2024 07:00
@nineteendo

nineteendo commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

Could you also configure pre-commit? https://devguide.python.org/getting-started/setup-building/#install-pre-commit

Misc/NEWS.d/next/Core and Builtins/2024-04-25-11-48-28.gh-issue-118216.SVg700.rst:1: default role used (hint: for inline literals, use double backticks) (default-role)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@thatbirdguythatuknownot
thatbirdguythatuknownot force-pushed the patch-33 branch from 6f7bc77 to bb766c7 Compare April 26, 2024 00:28
JelleZijlstra
JelleZijlstra reviewed May 2, 2024
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. Could you add an entry to the What's New for 3.13? This is arguably a change to the language semantics.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra JelleZijlstra self-assigned this May 2, 2024
@thatbirdguythatuknownot

thatbirdguythatuknownot commented May 2, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Got it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
thatbirdguythatuknownot and others added 6 commits May 2, 2024 14:05
@thatbirdguythatuknownot
Add dotted import check in future.c
cfa0f3e
@thatbirdguythatuknownot
Add dotted import check in compile.c
042554a
@thatbirdguythatuknownot
Add tests for dotted imports of __future__
536881e
@thatbirdguythatuknownot
Fix dotted import tests
46c8290
@blurb-it @thatbirdguythatuknownot
📜🤖 Added by blurb_it.
62d8487
@thatbirdguythatuknownot
Fix Markdown
9b908ee
@thatbirdguythatuknownot
thatbirdguythatuknownot force-pushed the patch-33 branch from bb766c7 to 9b908ee Compare May 2, 2024 06:05
@thatbirdguythatuknownot
Add entry to What's New in 3.13
019ef6f
JelleZijlstra
JelleZijlstra approved these changes May 2, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 2, 2024
@JelleZijlstra

JelleZijlstra commented May 2, 2024

Copy link
Copy Markdown
Member

@thatbirdguythatuknownot thanks! One piece of feedback: please avoid force-pushing to a PR branch, as it makes review somewhat harder. Just push a new commit and we'll squash them on merge. To update the PR branch with new commits from main, either click the "Update branch" button in GitHub or run git merge upstream/main (or whatever your remote is called) locally.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit 7c97dc8 into python:main May 2, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 2, 2024
@thatbirdguythatuknownot

thatbirdguythatuknownot commented May 2, 2024

Copy link
Copy Markdown
Contributor Author

Okay.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@thatbirdguythatuknownot @SonicField
pythongh-118216: Don't consider dotted __future__ imports (python#1…
3a5882a 
…18267)
@nineteendo nineteendo mentioned this pull request Oct 5, 2024
gh-124960: Fixed barry_as_FLUFL future flag does not work in new REPL #124999
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@thatbirdguythatuknownot @nineteendo @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.