GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117225: Move colorize functionality to own internal module by hugovk · Pull Request #118283 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Apr 25, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Here's the refactoring postponed from PR #117583.

  • Issue: Refresh doctest summary #117225

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk added 2 commits April 25, 2024 17:06
@hugovk
Move colorize functionality to own internal module
5a92ed9
@hugovk
Add _colorize.get_colors and refactor
a0bf815
@hugovk
hugovk requested a review from iritkatriel as a code owner April 25, 2024 14:14
@bedevere-app bedevere-app Bot mentioned this pull request Apr 25, 2024
Refresh doctest summary #117225
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 25, 2024
@hugovk hugovk mentioned this pull request Apr 25, 2024
gh-117225: Add color to doctest output #117583
Merged
@hugovk hugovk added the skip news label Apr 25, 2024
Privat33r-dev
Privat33r-dev reviewed Apr 25, 2024
View reviewed changes
Comment thread Lib/_colorize.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
nineteendo
nineteendo reviewed Apr 25, 2024
View reviewed changes

@nineteendo nineteendo left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these newlines.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/traceback.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/support/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
Precompute stubbed ANSIColors with no colours
005e44e
@hugovk
hugovk marked this pull request as draft April 26, 2024 07:31
@bedevere-app bedevere-app Bot removed the awaiting core review label Apr 26, 2024
@hugovk hugovk mentioned this pull request Apr 26, 2024
test_repl's test_no_memory: AssertionError: -6 not found in (1, 120) #118331
Closed
@mpage mpage mentioned this pull request Apr 26, 2024
gh-118331: Handle errors in _PyObject_SetManagedDict #118334
Merged
@colesbury colesbury mentioned this pull request Apr 26, 2024
Merge of #118283 and #118334 for CI #118336
Closed
Privat33r-dev
Privat33r-dev reviewed Apr 28, 2024
View reviewed changes
Comment thread Lib/_colorize.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
hugovk added 2 commits April 29, 2024 20:43
@hugovk
Merge branch 'main' into doctest-refactor-colorize
d5b06b3
@hugovk
Merge branch 'main' into doctest-refactor-colorize
d653c12
@hugovk
hugovk marked this pull request as ready for review April 29, 2024 21:37
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 29, 2024
@hugovk

hugovk commented Apr 29, 2024

Copy link
Copy Markdown
Member Author

Somehow managed to find two free-threaded bugs with this PR, but they're fixed now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk merged commit 3b3f8de into python:main May 1, 2024
@hugovk
hugovk deleted the doctest-refactor-colorize branch May 1, 2024 18:27
@bedevere-app bedevere-app Bot removed the awaiting core review label May 1, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@hugovk @SonicField
pythongh-117225: Move colorize functionality to own internal module (p…
1e0a640 
…ython#118283)
@dangotbanned dangotbanned mentioned this pull request Sep 7, 2026
Add stubs for stdlib _colorize module python/typeshed#16361
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel
2 more reviewers
@Privat33r-dev Privat33r-dev Privat33r-dev left review comments
@nineteendo nineteendo nineteendo left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @Privat33r-dev @nineteendo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.