GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117657: Don't specialize RESUME_CHECK when specialization is disabled by Fidget-Spinner · Pull Request #118349 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Apr 27, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It was showing up as a race in tsan. Though other races still bubble up with vectorcall so we cant remove it from the ignore list for now.

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Fidget-Spinner added 2 commits April 28, 2024 00:01
@Fidget-Spinner
Fix data race in _PyEval_EvalFrameDefault
3f25e12
@Fidget-Spinner
Re-enable supression
f0e3613
@Fidget-Spinner
Fidget-Spinner marked this pull request as ready for review April 27, 2024 16:24
@Fidget-Spinner
Fidget-Spinner requested review from gvanrossum and markshannon as code owners April 27, 2024 16:24
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 27, 2024
@Fidget-Spinner Fidget-Spinner added the skip news label Apr 27, 2024
@Fidget-Spinner Fidget-Spinner changed the title Disable RESUME_CHECK specialization on free-threaded builds gh-117657: Disable RESUME_CHECK specialization on free-threaded builds Apr 27, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 27, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
@Fidget-Spinner Fidget-Spinner added the topic-free-threading label Apr 28, 2024
@Fidget-Spinner
Fidget-Spinner requested review from DinoV, colesbury and swtaarrs April 29, 2024 12:45
swtaarrs
swtaarrs approved these changes Apr 30, 2024
View reviewed changes

@swtaarrs swtaarrs left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, but it might make sense to change the title to something like "Don't specialize RESUME_CHECK when specialization is disabled", which is what this is really doing. It's a good fix independent of free-threading concerns.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Fidget-Spinner Fidget-Spinner changed the title gh-117657: Disable RESUME_CHECK specialization on free-threaded builds gh-117657: Don't specialize RESUME_CHECK when specialization is disabled Apr 30, 2024
@Fidget-Spinner
Merge remote-tracking branch 'upstream/main' into eval_threadsafety
e47a81b
@Fidget-Spinner

Fidget-Spinner commented Apr 30, 2024

Copy link
Copy Markdown
Member Author

@DinoV made this atomic but we should still disable this if specialization is off anyways, for consistency's sake.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Fidget-Spinner added 2 commits May 1, 2024 03:46
@Fidget-Spinner
formatting
179a693
@Fidget-Spinner
regen cases
0f0f2df
@Fidget-Spinner
Fidget-Spinner enabled auto-merge (squash) April 30, 2024 21:25
@Fidget-Spinner
Fidget-Spinner merged commit 7fabcc7 into python:main Apr 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Apr 30, 2024
@bedevere-bot

bedevere-bot commented Apr 30, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.x has failed when building commit 7fabcc7.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1380/builds/134) and take a look at the build logs.
  4. Check if the failure is related to this commit (7fabcc7) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1380/builds/134

Failed tests:

  • test_posix

Failed subtests:

  • test_confstr - test.test_posix.PosixTester.test_confstr

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/AEE8DE28-E153-4624-933C-E9440AD6F955/data/Containers/Bundle/Application/02D17676-135F-425E-BBA6-933A29FA2609/iOSTestbed.app/python/lib/python3.13/test/test_posix.py", line 569, in test_confstr
    self.assertEqual(len(posix.confstr("CS_PATH")) > 0, True)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False != True
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@Fidget-Spinner @SonicField
pythongh-117657: Don't specialize RESUME_CHECK when specialization is…
09de650
… disabled (pythonGH-118349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swtaarrs swtaarrs swtaarrs approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@DinoV DinoV Awaiting requested review from DinoV
@colesbury colesbury Awaiting requested review from colesbury

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Fidget-Spinner @bedevere-bot @swtaarrs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.