GeezerVison is showing github.com — gh-117657: Don't specialize RESUME_CHECK when specialization is disabled by Fidget-Spinner · Pull Request #118349 · python/cpython
Conversation
Fidget-Spinner
commented
Apr 27, 2024
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
It was showing up as a race in tsan. Though other races still bubble up with vectorcall so we cant remove it from the ignore list for now.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Fidget-Spinner
changed the title
Disable RESUME_CHECK specialization on free-threaded builds
gh-117657: Disable RESUME_CHECK specialization on free-threaded builds
Apr 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, but it might make sense to change the title to something like "Don't specialize RESUME_CHECK when specialization is disabled", which is what this is really doing. It's a good fix independent of free-threading concerns.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Fidget-Spinner
changed the title
gh-117657: Disable RESUME_CHECK specialization on free-threaded builds
gh-117657: Don't specialize RESUME_CHECK when specialization is disabled
Apr 30, 2024
|
@DinoV made this atomic but we should still disable this if specialization is off anyways, for consistency's sake.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️
Hi! The buildbot iOS ARM64 Simulator 3.x has failed when building commit 7fabcc7.
What do you need to do:
- Don't panic.
- Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
- Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1380/builds/134) and take a look at the build logs.
- Check if the failure is related to this commit (7fabcc7) or if it is a false positive.
- If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.
You can take a look at the buildbot page here:
https://buildbot.python.org/all/#builders/1380/builds/134
Failed tests:
Failed subtests:
- test_confstr - test.test_posix.PosixTester.test_confstr
Summary of the results of the build (if available):
==
Click to see traceback logs
Traceback (most recent call last):
File "/Users/buildbot/Library/Developer/XCTestDevices/AEE8DE28-E153-4624-933C-E9440AD6F955/data/Containers/Bundle/Application/02D17676-135F-425E-BBA6-933A29FA2609/iOSTestbed.app/python/lib/python3.13/test/test_posix.py", line 569, in test_confstr
self.assertEqual(len(posix.confstr("CS_PATH")) > 0, True)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False != True
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|