GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115119: Update macOS installer to build with libmpdec 4.0.0 by erlend-aasland · Pull Request #118382 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 29, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Unvendor libmpdec sources #115119

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-115119: Update macOS installer to fetch and build libmpdecim…
bc04b90 
…al 2.5.1
@bedevere-app bedevere-app Bot mentioned this pull request Apr 29, 2024
Unvendor libmpdec sources #115119
Closed
15 tasks done
@erlend-aasland erlend-aasland added the skip news label Apr 29, 2024
@erlend-aasland

erlend-aasland commented Apr 29, 2024

Copy link
Copy Markdown
Contributor Author

There should be no user visible change for this; the installer ships with libmpdecimal 2.5.1 no matter if we use the bundled or external sources. Skipping news.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

This comment was marked as resolved.

Sign in to view
@erlend-aasland
erlend-aasland requested a review from ned-deily April 29, 2024 08:03
erlend-aasland added 2 commits April 29, 2024 12:38
@erlend-aasland
Revert spurious change
535c130
@erlend-aasland
Amend README and update CPython configure invocation
9bc8a60
@ned-deily ned-deily self-assigned this Apr 30, 2024
@ned-deily
fix library_recipes for mpdecimal
f7febe1
@erlend-aasland

erlend-aasland commented May 3, 2024

Copy link
Copy Markdown
Contributor Author

Thanks, @ned-deily! Feel free to take over and land this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland marked this pull request as ready for review May 3, 2024 06:47
@erlend-aasland
erlend-aasland requested a review from a team as a code owner May 3, 2024 06:47
@bedevere-app bedevere-app Bot added the awaiting core review label May 3, 2024
@ned-deily
Use libmpdec 4.0.0
57bd0ad
@ned-deily ned-deily changed the title gh-115119: Update macOS installer to fetch and build libmpdecimal 2.5.1 gh-115119: Update macOS installer to build with libmpdec 4.0.0 May 3, 2024
@ned-deily
ned-deily enabled auto-merge (squash) May 3, 2024 16:31
@ned-deily
ned-deily merged commit dd8f05f into python:main May 3, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label May 3, 2024
@erlend-aasland
erlend-aasland deleted the mac/build-libmpdec branch May 5, 2024 20:03
@erlend-aasland

erlend-aasland commented May 5, 2024

Copy link
Copy Markdown
Contributor Author

Thanks again, Ned!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@erlend-aasland @ned-deily @SonicField
pythongh-115119: Update macOS installer to build with libmpdec 4.0.0 (p…
1571858 
…ythonGH-118382)

Co-authored-by: Ned Deily <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily Awaiting requested review from ned-deily

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ned-deily ned-deily

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @ned-deily
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.