GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110850: Add PyTime_TimeRaw() function by vstinner · Pull Request #118394 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 29, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add "Raw" variant of PyTime functions:

  • PyTime_MonotonicRaw()
  • PyTime_PerfCounterRaw()
  • PyTime_TimeRaw()

Changes:

  • Add documentation and tests. Tests release the GIL while calling raw clock functions.
  • py_get_system_clock() and py_get_monotonic_clock() now check that the GIL is hold by the caller if raise_exc is non-zero.
  • Reimplement "Unchecked" functions with raw clock functions.
  • Issue: Please expose _PyTime_t, _PyTime_FromTimeval, and _PyTime_AsSecondsDouble as public APIs #110850

📚 Documentation preview 📚: https://cpython-previews--118394.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-110850: Add PyTime_TimeRaw() function
9a69ac4 
Add "Raw" variant of PyTime functions:

* PyTime_MonotonicRaw()
* PyTime_PerfCounterRaw()
* PyTime_TimeRaw()

Changes:

* Add documentation and tests. Tests release the GIL while calling
  raw clock functions.
* py_get_system_clock() and py_get_monotonic_clock() now check that
  the GIL is hold by the caller if raise_exc is non-zero.
* Reimplement "Unchecked" functions with raw clock functions.
@vstinner
vstinner requested review from abalkin and pganssle as code owners April 29, 2024 15:19
@bedevere-app bedevere-app Bot mentioned this pull request Apr 29, 2024
Please expose _PyTime_t, _PyTime_FromTimeval, and _PyTime_AsSecondsDouble as public APIs #110850
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 29, 2024
@vstinner

vstinner commented Apr 29, 2024

Copy link
Copy Markdown
Member Author

cc @encukou
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Apr 29, 2024
gh-110850: Change PyTime C API error handling capi-workgroup/decisions#15
Closed
encukou
encukou reviewed May 1, 2024
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I have a few suggestions, which I've also tested locally. I've sent them as a PR: vstinner#2

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/c-api/time.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_testcapi/time.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/pytime.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
encukou and others added 2 commits May 1, 2024 17:35
@encukou
Suggestions for time_raw (#2)
615f8a0
@vstinner
Use Py_FatalError() in debug mode
283bc63
@vstinner

vstinner commented May 1, 2024

Copy link
Copy Markdown
Member Author

@encukou: I applied your suggestion, but I replaced the assert() with Py_FatalError(). Also, I added a code path with (void) (to ignore the result) to ignore a potential compiler warning about unused result variable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 1, 2024

Copy link
Copy Markdown
Member Author

Don't bother too much about "Unchecked" functions. Once this PR will land, I will write a PR to remove "Unchecked" functions (use "Raw" functions instead).
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou
encukou approved these changes May 1, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 1, 2024
@encukou

encukou commented May 1, 2024

Copy link
Copy Markdown
Member

Thanks!
Looking forward to that :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner enabled auto-merge (squash) May 1, 2024 17:04
@vstinner
vstinner merged commit b52c753 into python:main May 1, 2024
@vstinner
vstinner deleted the time_raw branch May 1, 2024 18:05
@bedevere-app bedevere-app Bot removed the awaiting merge label May 1, 2024
@encukou encukou mentioned this pull request May 2, 2024
gh-110850: Expose _PyTime_TimeUnchecked function for now #116463
Closed
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@vstinner @encukou @SonicField
pythongh-110850: Add PyTime_TimeRaw() function (python#118394)
5cb0055 
Add "Raw" variant of PyTime functions:

* PyTime_MonotonicRaw()
* PyTime_PerfCounterRaw()
* PyTime_TimeRaw()

Changes:

* Add documentation and tests. Tests release the GIL while calling
  raw clock functions.
* py_get_system_clock() and py_get_monotonic_clock() now check that
  the GIL is hold by the caller if raise_exc is non-zero.
* Reimplement "Unchecked" functions with raw clock functions.

Co-authored-by: Petr Viktorin <[email protected]>
@cjavad cjavad mentioned this pull request May 12, 2024
gh-118950: Fix SSLProtocol.connection_lost not being called when OSError is thrown on asyncio.write. #118960
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.