GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109975: Document crypt_r as a possible replacement of crypt by hroncok · Pull Request #118439 · python/cpython

Conversation

@hroncok

@hroncok hroncok commented Apr 30, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: What's New in Python 3.13 (copyediting) #109975

📚 Documentation preview 📚: https://cpython-previews--118439.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hroncok
pythongh-109975: Document crypt_r as a possible replacement of crypt
0963621
@bedevere-app bedevere-app Bot mentioned this pull request Apr 30, 2024
What's New in Python 3.13 (copyediting) #109975
Closed
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 30, 2024
@nineteendo

nineteendo commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

It's worth mentioning you're the author of the crypt_r module.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hroncok

hroncok commented Apr 30, 2024

Copy link
Copy Markdown
Contributor Author

I am not the author (it's dissected from CPython 3.12, authored by others), but I am indeed a maintainer. Other modules in the list do not have their authors/maintainers mentioned. Should I put a disclaimer to the commit message?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nineteendo

nineteendo commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

No, I just meant for the pull request, as you're kind of advertising the module.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Apr 30, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duly noted @hroncok is a maintainer, thank you for creating the package and for this PR.

Perhaps drop a note at https://discuss.python.org/t/pep-594-has-been-implemented-python-3-13-removes-20-stdlib-modules/27124 as well?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 30, 2024
@hugovk
hugovk merged commit f7747f7 into python:main Apr 30, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 30, 2024
@hroncok

hroncok commented Apr 30, 2024

Copy link
Copy Markdown
Contributor Author

Perhaps drop a note at https://discuss.python.org/t/pep-594-has-been-implemented-python-3-13-removes-20-stdlib-modules/27124 as well?

https://discuss.python.org/t/pep-594-has-been-implemented-python-3-13-removes-20-stdlib-modules/27124/14
hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hroncok
hroncok deleted the crypt_r branch April 30, 2024 23:28
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@hroncok @SonicField
pythongh-109975: Document crypt_r as a possible replacement of crypt (p…
033f9cc 
…ython#118439)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hroncok @nineteendo @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.