GeezerVison

Though, I do wonder if it's worth adding commit rules or similar to catch formatting issues? Would be nice to just have this tackled automagically?

Agreed.

There's already a mypy job that runs over these files as part of CI. It was easy to add since it already existed for other parts of the codebase. Adding black and pylint would mean actually doing some work and adding new jobs, which I wasn't up for at the time (plus they tend to be more "style" than "correctness", so they feel less important).

Adding black and pylint would mean actually doing some work and adding new jobs, which I wasn't up for at the time

They can be added in .pre-commit-config.yaml. Make sure to set files: so it only runs on JIT code.

We can add Black to pre-commit (after the Ruff config) like:

  - repo: https://github.com/psf/black-pre-commit-mirror
    rev: 24.4.2
    hooks:
      - id: black
    files: TODO

We can run pylint via the existing Ruff by selecting the PL rules in a local .ruff.toml in the JIT directory, then add that to the pre-commit config. You can compare the Lib/test and Argument Clinic ones which also have their own .ruff.toml.

(cc @AlexWaygood FYI)

(plus they tend to be more "style" than "correctness", so they feel less important)

(Yeah, I usually only run pylint occasionally and don't in CI because it's quite noisy, but if you've resolved them and want to maintain that, I recommend doing it this way.)

@brandtbucher If you think that'd be nice, I can take a look at adding a job to do this in .pre-commit-config.yaml for JIT files.

That would be great, yeah. I'm not picky about the set of rules itself, so if the defaults pass then we can just use those.

This banner is printed even when using --enable-experimental-jit=interpreter. That seems wrong?

Hm. This script should only be part of the Makefile if we're actually building the JIT. It looks like jit_stencils.h is currently generated if the option is anything other than no currently.

So we should update configure.ac to only build the JIT if the option is yes or yes-off.

Hm. This script should only be part of the Makefile if we're actually building the JIT. It looks like jit_stencils.h is currently generated if the option is anything other than no currently.

So we should update configure.ac to only build the JIT if the option is yes or yes-off.

Yeah, I'm on it.

Thanks!