GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115119: Update Windows installer to mpdecimal 4.0.0 by erlend-aasland · Pull Request #118506 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 2, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Unvendor libmpdec sources #115119

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland
pythongh-115119: Update Windows installer to mpdecimal 4.0.0
6c56d3d
@bedevere-app bedevere-app Bot mentioned this pull request May 2, 2024
Unvendor libmpdec sources #115119
Closed
15 tasks done
@erlend-aasland

erlend-aasland commented May 2, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@sethmlarson, I tried to use generate_sbom.py:

$ python3 Tools/build/generate_sbom.py
Version '4.0.0' for package 'mpdecimal not in all 'externalRefs[].referenceLocator' fields

Do I have to manually edit Misc/sbom.spdx.json?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Eclips4

Eclips4 commented May 2, 2024

Copy link
Copy Markdown
Member

@SethMichaelLarson, I tried to use generate_sbom.py:

$ python3 Tools/build/generate_sbom.py
Version '4.0.0' for package 'mpdecimal not in all 'externalRefs[].referenceLocator' fields

Do I have to manually edit Misc/sbom.spdx.json?

I think you mean @sethmlarson :)

erlend-aasland reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sethmlarson

sethmlarson commented May 2, 2024

Copy link
Copy Markdown
Contributor

Thanks for reporting this @erlend-aasland and apologies for the trouble. It wasn't the intent to require the user to update the CPE value, I've opened a PR to automatically update the CPE version value.

If you need to get this update in ASAP, I recommend updating the CPE value manually in Misc/externals.spdx.json.

erlend-aasland reacted with heart emoji erlend-aasland reacted with eyes emoji
All reactions
  • ❤️ 1 reaction
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added 2 commits May 3, 2024 08:41
@erlend-aasland
Pull in main
7edaf79
@erlend-aasland
Try to update sbom stuff manually
3031684
@erlend-aasland

erlend-aasland commented May 3, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for reporting this @erlend-aasland and apologies for the trouble. It wasn't the intent to require the user to update the CPE value, I've opened a PR to automatically update the CPE version value.

Thank you so much!

If you need to get this update in ASAP, I recommend updating the CPE value manually in Misc/externals.spdx.json.

I tried to manually update the value in 3031684.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added 2 commits May 3, 2024 08:59
@erlend-aasland
No newline at end of file
6e9475a
@erlend-aasland
Fix checksum
89aac1a
@erlend-aasland
erlend-aasland marked this pull request as ready for review May 3, 2024 07:29
@erlend-aasland
erlend-aasland requested review from a team and sethmlarson as code owners May 3, 2024 07:29
@bedevere-app bedevere-app Bot added the awaiting core review label May 3, 2024
zooba
zooba approved these changes May 3, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 3, 2024
sethmlarson
sethmlarson approved these changes May 3, 2024
View reviewed changes

@sethmlarson sethmlarson left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
zware
zware approved these changes May 3, 2024
View reviewed changes
@erlend-aasland
erlend-aasland merged commit 1324502 into python:main May 3, 2024
@erlend-aasland
erlend-aasland deleted the libmpdec-4.0.0-win branch May 3, 2024 16:00
@bedevere-app bedevere-app Bot removed the awaiting merge label May 3, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@erlend-aasland @SonicField
pythongh-115119: Update Windows installer to mpdecimal 4.0.0 (python#…
4ed3d44
…118506)
@zanieb zanieb mentioned this pull request Oct 14, 2024
Bump mpdecimal from 2.5.1 -> 4.0.0 astral-sh/python-build-standalone#353
Merged
@Ahajha Ahajha mentioned this pull request Nov 29, 2024
cpython: add 3.13.1 conan-io/conan-center-index#25536
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes
@zware zware zware approved these changes
@sethmlarson sethmlarson sethmlarson approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @Eclips4 @sethmlarson @zooba @zware
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.