GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110850: Remove _PyTime_TimeUnchecked() function by vstinner · Pull Request #118552 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 3, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Use the new public Raw functions:

  • _PyTime_PerfCounterUnchecked() with PyTime_PerfCounterRaw()
  • _PyTime_TimeUnchecked() with PyTime_TimeRaw()
  • _PyTime_MonotonicUnchecked() with PyTime_MonotonicRaw()

Remove internal functions:

  • _PyTime_PerfCounterUnchecked()
  • _PyTime_TimeUnchecked()
  • _PyTime_MonotonicUnchecked()
  • Issue: Please expose _PyTime_t, _PyTime_FromTimeval, and _PyTime_AsSecondsDouble as public APIs #110850

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot mentioned this pull request May 3, 2024
Please expose _PyTime_t, _PyTime_FromTimeval, and _PyTime_AsSecondsDouble as public APIs #110850
Closed
@vstinner
vstinner force-pushed the remove_time_unchecked branch from d927040 to 312b7d5 Compare May 3, 2024 15:42
@vstinner vstinner added the skip news label May 3, 2024
@vstinner
vstinner force-pushed the remove_time_unchecked branch 2 times, most recently from 6c82b37 to 68398ec Compare May 4, 2024 08:27
@vstinner
vstinner marked this pull request as ready for review May 4, 2024 08:27
@vstinner
vstinner requested review from abalkin, kumaraditya303 and pganssle as code owners May 4, 2024 08:27
@bedevere-app bedevere-app Bot added the awaiting core review label May 4, 2024
@vstinner

vstinner commented May 4, 2024

Copy link
Copy Markdown
Member Author

@colesbury: Would you mind to proofread the parking_lot.c changes?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
pythongh-110850: Remove _PyTime_TimeUnchecked() function
8888a1e 
Use the new public Raw functions:

* _PyTime_PerfCounterUnchecked() with PyTime_PerfCounterRaw()
* _PyTime_TimeUnchecked() with PyTime_TimeRaw()
* _PyTime_MonotonicUnchecked() with PyTime_MonotonicRaw()

Remove internal functions:

* _PyTime_PerfCounterUnchecked()
* _PyTime_TimeUnchecked()
* _PyTime_MonotonicUnchecked()
@vstinner
vstinner force-pushed the remove_time_unchecked branch from 68398ec to 8888a1e Compare May 4, 2024 08:29
@colesbury

colesbury commented May 4, 2024

Copy link
Copy Markdown
Contributor

Look correct to me
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit aa61f8b into python:main May 5, 2024
@vstinner
vstinner deleted the remove_time_unchecked branch May 5, 2024 10:15
@bedevere-app bedevere-app Bot removed the awaiting core review label May 5, 2024
@vstinner

vstinner commented May 5, 2024

Copy link
Copy Markdown
Member Author

Merged, thanks for the review 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@vstinner @SonicField
pythongh-110850: Remove _PyTime_TimeUnchecked() function (python#118552)
bc1fc56 
Use the new public Raw functions:

* _PyTime_PerfCounterUnchecked() with PyTime_PerfCounterRaw()
* _PyTime_TimeUnchecked() with PyTime_TimeRaw()
* _PyTime_MonotonicUnchecked() with PyTime_MonotonicRaw()

Remove internal functions:

* _PyTime_PerfCounterUnchecked()
* _PyTime_TimeUnchecked()
* _PyTime_MonotonicUnchecked()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.