GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-101525: Skip test_gdb if the binary is relocated by BOLT. by corona10 · Pull Request #118572 · python/cpython

gh-101525: Skip test_gdb if the binary is relocated by BOLT. #118572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

corona10 merged 10 commits into python:main from corona10:gh-101525-test

Sep 2, 2024

Uh oh!

There was an error while loading. Please reload this page.

Merged

gh-101525: Skip test_gdb if the binary is relocated by BOLT. #118572

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

10 commits

Select commit Hold shift + click to select a range

8755316

gh-101525: Skip test_gdb if the binary is BOLTed.

corona10 Aug 31, 2024

0e9d019

Address code review

corona10 Sep 2, 2024

File filter

Filter by extension .py (3) .rst (1) All 2 file types selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

5 changes: 5 additions & 0 deletions 5 Lib/test/libregrtest/utils.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -343,6 +343,11 @@ def get_build_info():
		if support.check_cflags_pgo():
		# PGO (--enable-optimizations)
		optimizations.append('PGO')

Comment thread corona10 marked this conversation as resolved. Resolved Uh oh! There was an error while loading. Please reload this page.
		if support.check_bolt_optimized():
		# BOLT (--enable-bolt)
		optimizations.append('BOLT')

		if optimizations:
		build.append('+'.join(optimizations))

Expand Down

9 changes: 9 additions & 0 deletions 9 Lib/test/support/__init__.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -866,6 +866,15 @@ def check_cflags_pgo():
		return any(option in cflags_nodist for option in pgo_options)


		def check_bolt_optimized():
		# Always return false, if the platform is WASI,
		# because BOLT optimization does not support WASM binary.
		if is_wasi:
		return False
		config_args = sysconfig.get_config_var('CONFIG_ARGS') or ''
		return '--enable-bolt' in config_args


		Py_GIL_DISABLED = bool(sysconfig.get_config_var('Py_GIL_DISABLED'))

		def requires_gil_enabled(msg="needs the GIL enabled"):
Expand Down

3 changes: 3 additions & 0 deletions 3 Lib/test/test_gdb/__init__.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -24,6 +24,9 @@
		if support.check_cflags_pgo():
		raise unittest.SkipTest("test_gdb is not reliable on PGO builds")

		if support.check_bolt_optimized():
		raise unittest.SkipTest("test_gdb is not reliable on BOLT optimized builds")


		def load_tests(*args):
		return support.load_package_tests(os.path.dirname(__file__), *args)

2 changes: 2 additions & 0 deletions 2 Misc/NEWS.d/next/Tests/2024-05-04-22-56-41.gh-issue-101525.LHK166.rst

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Skip ``test_gdb`` if the binary is relocated by BOLT.
Comment thread picnixz marked this conversation as resolved. Resolved Uh oh! There was an error while loading. Please reload this page.
		Patch by Donghee Na.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.