GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117139: Fix missing semicolon by Fidget-Spinner · Pull Request #118573 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented May 4, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This file isn't used at the moment, but it's still good not to have invalid syntax.

  • Issue: Set up tagged pointers in the evaluation stack #117139

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
Fix missing semicolon
891c24b
@bedevere-app bedevere-app Bot added the awaiting core review label May 4, 2024
@Fidget-Spinner Fidget-Spinner added skip news and removed awaiting core review labels May 4, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 4, 2024
Set up tagged pointers in the evaluation stack #117139
Closed
corona10
corona10 approved these changes May 4, 2024
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ken can make mistake!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting merge label May 4, 2024
@Fidget-Spinner
Update test_frozenmain.h
17c8ace
@Fidget-Spinner
Fidget-Spinner requested a review from ericsnowcurrently as a code owner May 4, 2024 14:13
@Fidget-Spinner

Fidget-Spinner commented May 4, 2024

Copy link
Copy Markdown
Member Author

Ken can make mistake!

Yes I'm not a robot :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Fidget-Spinner enabled auto-merge (squash) May 4, 2024 14:38
@Fidget-Spinner
Fidget-Spinner disabled auto-merge May 4, 2024 15:19
@Fidget-Spinner
Revert "Update test_frozenmain.h"
d52fe39 
This reverts commit 17c8ace.
@Fidget-Spinner
Fidget-Spinner enabled auto-merge (squash) May 4, 2024 15:24
@Fidget-Spinner
Fidget-Spinner merged commit 978fba5 into python:main May 4, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 4, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@Fidget-Spinner @SonicField
pythongh-117139: Fix missing semicolon (pythonGH-118573)
2670633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Fidget-Spinner @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.