GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118518: Use the raw syscall directly for gettid by pablogsal · Pull Request #118592 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented May 5, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Allow perf to work without frame pointers #118518

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pythongh-118518: Use the raw syscall directly for gettid
a08d6b4
@pablogsal
pablogsal requested a review from brandtbucher as a code owner May 5, 2024 09:51
@bedevere-app bedevere-app Bot added the awaiting core review label May 5, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 5, 2024
Allow perf to work without frame pointers #118518
Closed
@pablogsal pablogsal mentioned this pull request May 5, 2024
gh-118518: Allow perf to work without frame pointers #112254
Merged
@pablogsal

pablogsal commented May 5, 2024

Copy link
Copy Markdown
Member Author

!buildbot AMD64 RHEL8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 5, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit a08d6b4 🤖

The command will test the builders whose names match following regular expression: AMD64 RHEL8

The builders matched are:

  • AMD64 RHEL8 LTO PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR
  • AMD64 RHEL8 PR
  • AMD64 RHEL8 Refleaks PR
  • AMD64 RHEL8 LTO + PGO PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal enabled auto-merge (squash) May 5, 2024 10:26
@pablogsal pablogsal added the skip news label May 5, 2024
@pablogsal
pablogsal merged commit aeb36c5 into python:main May 5, 2024
@pablogsal
pablogsal deleted the gettid branch May 5, 2024 12:37
@bedevere-app bedevere-app Bot removed the awaiting core review label May 5, 2024
ericsnowcurrently
ericsnowcurrently reviewed May 6, 2024
View reviewed changes
Comment thread Python/perf_jit_trampoline.c
ev.base.time_stamp = get_current_monotonic_ticks();
ev.process_id = getpid();
ev.thread_id = gettid();
ev.thread_id = syscall(SYS_gettid);

@ericsnowcurrently ericsnowcurrently May 6, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would make sense to leverage the existing thread API, e.g. PyThread_get_thread_native_id()?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@pablogsal pablogsal May 6, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that first but that has a check first for !initialized that calls PyThread_init_thread and that was causing problems when fork happens.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@pablogsal @SonicField
pythongh-118518: Use the raw syscall directly for gettid (python#118592)
cb20391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently left review comments
@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pablogsal @bedevere-bot @ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.