GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118613: Fix error handling of `_PyEval_GetFrameLocals` in `ceval.c` by sobolevn · Pull Request #118614 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented May 5, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refs #115153

  • Issue: Missing error handling in _PyEval_GetFrameLocals in ceval.c #118613

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-118613: Fix error handling of _PyEval_GetFrameLocals in `c…
ab44c4a 
…eval.c`
@sobolevn
sobolevn requested a review from gaogaotiantian May 5, 2024 21:28
@sobolevn
sobolevn requested review from gvanrossum and markshannon as code owners May 5, 2024 21:28
@bedevere-app bedevere-app Bot added the awaiting core review label May 5, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 5, 2024
Missing error handling in _PyEval_GetFrameLocals in ceval.c #118613
Closed
@sobolevn sobolevn added the skip news label May 5, 2024
@sobolevn
PyDict_Update handling
652289d
@gaogaotiantian

gaogaotiantian commented May 5, 2024

Copy link
Copy Markdown
Member

While you are on this matter, could you change the else if part to an assertion? The locals should either be a FrameLocalsProxy or a mapping at least. Just remove the else if case and change that to an assertion. Then you can always return locals at the end of the function.

Otherwise, logically, you need to handle the else case which should not ever exist.
sobolevn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Address review
d1e1c5d
gaogaotiantian
gaogaotiantian approved these changes May 5, 2024
View reviewed changes
gvanrossum
gvanrossum approved these changes May 6, 2024
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 6, 2024
@sobolevn
sobolevn merged commit a8e5fed into python:main May 6, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 6, 2024
@sobolevn
sobolevn deleted the issue-118613 branch May 6, 2024 07:35
@sobolevn

sobolevn commented May 6, 2024

Copy link
Copy Markdown
Member Author

Since #115153 was not backported, I also don't backport.

Thanks everyone! 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gaogaotiantian

gaogaotiantian commented May 6, 2024

Copy link
Copy Markdown
Member

This piece of code has only been in main for like 2 days so there's no need to backport :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@sobolevn @SonicField
pythongh-118613: Fix error handling of _PyEval_GetFrameLocals in `c…
86213f9 
…eval.c` (python#118614)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@gaogaotiantian gaogaotiantian gaogaotiantian approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @gaogaotiantian @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.