GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115119: Bump CI to use Ubuntu 22.04 by erlend-aasland · Pull Request #118631 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 6, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Ubuntu 22.04 ships with mpdecimal 2.5.1, installable using apt install libmpdec-dev.

  • Issue: Unvendor libmpdec sources #115119

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-115119: Bump CI to use Ubuntu 22.04
0842113 
Ubuntu 22.04 ships with mpdecimal 2.5.1, installable using 'apt install libmpdec3'
@erlend-aasland
erlend-aasland requested a review from ezio-melotti as a code owner May 6, 2024 07:21
@erlend-aasland erlend-aasland added the skip news label May 6, 2024
@erlend-aasland
erlend-aasland requested a review from hugovk as a code owner May 6, 2024 07:21
@bedevere-app bedevere-app Bot added the awaiting core review label May 6, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 6, 2024
Unvendor libmpdec sources #115119
Closed
15 tasks done
@erlend-aasland

erlend-aasland commented May 6, 2024

Copy link
Copy Markdown
Contributor Author

FTR, the mpdecimal library provided by Ubuntu 20.04 is version 2.4.x; too old for CPython which requires mpdecimal 2.5.0 or newer.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented May 6, 2024

Copy link
Copy Markdown
Contributor Author

We might want to backport this to 3.12.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request May 6, 2024
gh-115119: Default to --with-system-libmpdec=yes #118539
Merged
hugovk
hugovk approved these changes May 6, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to backport this to 3.12.

Yep, let's keep them in sync for fewer surprises.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 6, 2024
@erlend-aasland erlend-aasland added the needs backport to 3.12 only security fixes label May 6, 2024
@erlend-aasland
erlend-aasland merged commit 716ec4b into python:main May 6, 2024
@erlend-aasland
erlend-aasland deleted the ci/ubuntu-22.04 branch May 6, 2024 08:39
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@bedevere-app bedevere-app Bot removed the awaiting merge label May 6, 2024
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@miss-islington-app miss-islington-app Bot assigned erlend-aasland May 6, 2024
@bedevere-app

bedevere-app Bot commented May 6, 2024

Copy link
Copy Markdown

GH-118634 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 6, 2024
erlend-aasland added a commit that referenced this pull request May 6, 2024
@erlend-aasland
[3.12] gh-115119: Bump CI to use Ubuntu 22.04 (#118631) (#118634)
a81fe2a 
Ubuntu 22.04 ships with mpdecimal 2.5.1, installable using 'apt install libmpdec-dev'.
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@erlend-aasland @SonicField
pythongh-115119: Bump CI to use Ubuntu 22.04 (python#118631)
db8f8e1 
Ubuntu 22.04 ships with mpdecimal 2.5.1, installable using 'apt install libmpdec-dev'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@erlend-aasland erlend-aasland

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.