GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116322: Rename PyModule_ExperimentalSetGIL to PyUnstable_Module_SetGIL by encukou · Pull Request #118645 · python/cpython

Conversation

@encukou

@encukou encukou commented May 6, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The PyUnstable prefix has defined semantics and workflow, and generates a note in the docs:

image

  • Issue: Allow C extensions to declare compatibility with free-threading #116322

📚 Documentation preview 📚: https://cpython-previews--118645.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@encukou
pythongh-116322: Rename PyModule_ExperimentalSetGIL to PyUnstable_Mod…
82f3c58 
…ule_SetGIL
@encukou
encukou requested a review from colesbury May 6, 2024 12:48
@encukou
encukou requested review from abalkin, ericsnowcurrently and pganssle as code owners May 6, 2024 12:48
@bedevere-app bedevere-app Bot added the awaiting core review label May 6, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 6, 2024
Allow C extensions to declare compatibility with free-threading #116322
Closed
@encukou encukou mentioned this pull request May 6, 2024
gh-116322: Add Py_mod_gil module slot #116882
Merged
@colesbury
colesbury requested a review from swtaarrs May 6, 2024 15:36
colesbury
colesbury approved these changes May 6, 2024
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @swtaarrs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 6, 2024
swtaarrs
swtaarrs approved these changes May 6, 2024
View reviewed changes

@swtaarrs swtaarrs left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
encukou merged commit 417dd3a into python:main May 6, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 6, 2024
@encukou
encukou deleted the experimental_unstable branch May 6, 2024 16:59
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@encukou @SonicField
pythongh-116322: Rename PyModule_ExperimentalSetGIL to PyUnstable_Mod…
7678b39 
…ule_SetGIL (pythonGH-118645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swtaarrs swtaarrs swtaarrs approved these changes
@colesbury colesbury colesbury approved these changes
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @swtaarrs @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.