GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112075: use per-thread dict version pool by DinoV · Pull Request #118676 · python/cpython

Conversation

@DinoV

@DinoV DinoV commented May 6, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

We want to avoid contention on the dict version. This moves to using a per-thread pool of 256 dict versions that we can allocate from without hitting the atomic operation for the main thread.

  • Issue: Make dict objects thread-safe in --disable-gil builds #112075

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DinoV
DinoV requested a review from ericsnowcurrently as a code owner May 6, 2024 22:20
@bedevere-app bedevere-app Bot added the awaiting core review label May 6, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 6, 2024
Make dict objects thread-safe in --disable-gil builds #112075
Closed
@DinoV DinoV added skip news topic-free-threading labels May 6, 2024
@DinoV
DinoV requested a review from colesbury May 6, 2024 22:21
colesbury
colesbury reviewed May 6, 2024
View reviewed changes
Comment thread Include/internal/pycore_dict.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
colesbury
colesbury approved these changes May 6, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 6, 2024
DinoV added 2 commits May 6, 2024 16:43
@DinoV
use thread state set of dict versions
2d3e018
@DinoV
Fix increment
adb5e13
@DinoV
DinoV force-pushed the nogil_dict_version branch from 4d6906a to adb5e13 Compare May 6, 2024 23:43
@DinoV
DinoV enabled auto-merge (squash) May 7, 2024 00:00
@DinoV
DinoV merged commit ff6cbb2 into python:main May 7, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 7, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@DinoV @SonicField
pythongh-112075: use per-thread dict version pool (python#118676)
a540070 
use thread state set of dict versions
@DinoV
DinoV deleted the nogil_dict_version branch May 31, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@DinoV @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.