GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118518: Rename `PYTHONPERFJITSUPPORT` and `-X perfjit` with underscores by hugovk · Pull Request #118693 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented May 7, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR renames:

  • env var PYTHONPERFJITSUPPORT -> PYTHON_PERF_JIT_SUPPORT
  • -X perfjit -> -X perf_jit

From Python 3.13, new environment variables should use underscores:

  • https://devguide.python.org/developer-workflow/stdlib/#adding-a-new-environment-variable
  • https://discuss.python.org/t/change-environment-variable-style/35180

I don't think we have a policy for -X options, and we have a mix (I think newer ones tend to use underscores?), but I recommend using an underscore here too for the same accessibility and readability reasons as env vars. Plus consistency with the env var.

For example, we added PYTHON_CPU_COUNT and -X cpu_count in 3.13.

cc @pablogsal

  • Issue: Allow perf to work without frame pointers #118518

📚 Documentation preview 📚: https://cpython-previews--118693.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
hugovk added 2 commits May 7, 2024 12:40
@hugovk
Rename PYTHONPERFJITSUPPORT to use underscores: PYTHON_PERF_JIT_SUPPORT
d454f29
@hugovk
Rename perfjit to use underscores: perf_jit
54db163
@hugovk
hugovk requested review from ericsnowcurrently and ezio-melotti as code owners May 7, 2024 09:52
@bedevere-app bedevere-app Bot added the awaiting core review label May 7, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 7, 2024
Allow perf to work without frame pointers #118518
Closed
@hugovk
hugovk force-pushed the PYTHON_PERF_JIT_SUPPORT branch from 13f27bb to 54db163 Compare May 7, 2024 09:53
@hugovk hugovk changed the title gh-118518: Rename PYTHONPERFJITSUPPORT and -X perfjit gh-118518: Rename PYTHONPERFJITSUPPORT and -X perfjit with underscores May 7, 2024
pablogsal
pablogsal approved these changes May 7, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 7, 2024
@pablogsal
pablogsal enabled auto-merge (squash) May 7, 2024 10:35
@hugovk

hugovk commented May 7, 2024

Copy link
Copy Markdown
Member Author

The TSAN job timed out: https://github.com/python/cpython/actions/runs/8983317059/job/24672835971?pr=118693

I've restarted it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit 0485922 into python:main May 7, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 7, 2024
@hugovk
hugovk deleted the PYTHON_PERF_JIT_SUPPORT branch May 7, 2024 11:48
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@hugovk @SonicField
pythongh-118518: Rename PYTHONPERFJITSUPPORT and -X perfjit with …
a807a17 
…underscores (python#118693)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.