GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||
GeezerVison is showing github.com — gh-109975: Update 'What's New in Python 3.13' for beta by hugovk · Pull Request #118694 · python/cpython Conversation
|
| Improve validation logic in the C implementation of :meth:`datetime.fromisoformat` | ||
| to better handle invalid years. Patch by Vlad Efanov. | ||
| Improve validation logic in the C implementation of | ||
| :meth:`datetime.datetime.fromisoformat` to better handle invalid years. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why these weren't caught on the PR adding them? Is there some configuration change we can make so that NEWS entries get linted properly by Sphinx?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do lint them with Sphinx Lint, but that doesn't catch everything, especially not bad references.
We only check for warnings from a Sphinx build in files under Doc/:
cpython/Doc/tools/check-warnings.py
Lines 212 to 216 in c4f9823
| all_rst = { | |
| str(rst) | |
| for rst in Path("Doc/").rglob("*.rst") | |
| if rst.parts[1] not in EXCLUDE_SUBDIRS | |
| } |
We ignore those that are in .nitignore because they've not been "cleaned" yet, because we don't want to hassle people over warnings which they didn't introduce.
Similarly, we ignore the news files, because during the Sphinx build, they get compiled into a giant 45k line build/NEWS which has 700+ warnings (and growing, because we don't check them).
And so we don't want to warn for every single PR that adds a small NEWS blurb about those 700 warnings that they didn't introduce.
New entries are added to the top of the compiled NEWS file. One option would be to add a check to ensure the top X lines remain clean. Most NEWS entries are under 10 lines long, and the biggest right now is 18 lines, so checking something like the top 200 or so would prevent new warnings being introduced.
I started work on this in February, see hugovk#61. I'll pick this up again.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
-
❤️ 1 reaction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see PR #119221.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
Reviewers
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assignedLabels
Projects
Milestone
No milestoneDevelopment
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
3 participants
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.