GeezerVison is showing github.com — gh-109653: What's new: Note improved import times for several stdlib modules in Python 3.13 by AlexWaygood · Pull Request #118697 · python/cpython
Conversation
AlexWaygood
commented
May 7, 2024
•
edited by github-actions
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
danielhollas and ofek reacted with heart emoji
…tdlib modules in Python 3.13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to include some numbers if appropriate, maybe as a range?
Something like:
* Several standard library modules have had their import times significantly
- improved.
+ improved, from around XX% to YY%.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Would be nice to include some numbers if appropriate, maybe as a range?
I'll add some ballpark figures.
I'm slightly wary of being too precise, because you'll only e.g. enjoy the typing import speedup if you've also avoided importing contextlib and re (and anything that might import contextlib and re) elsewhere in your code. If you're writing a small CLI tool where startup times are really important, it's more likely that you're already being careful about that kind of thing, so it's more likely you'll see an improvement. But as soon as you e.g. import asyncio, it's game over.
|
hugovk reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Yep, a rough ballpark is perfect. As you say, this really helps CLIs rather than big apps or libraries. People who really care can click through to the PRs to see the full details.
|
AlexWaygood reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
hugovk
hugovk approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|