GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111201: Allow bracketed paste to work by pablogsal · Pull Request #118700 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented May 7, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: A new Python REPL #111201

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hauntsaninja reacted with hooray emoji hauntsaninja reacted with heart emoji hauntsaninja reacted with rocket emoji
All reactions
  • 🎉 1 reaction
  • ❤️ 1 reaction
  • 🚀 1 reaction
@bedevere-app bedevere-app Bot added the awaiting core review label May 7, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 7, 2024
A new Python REPL #111201
Closed
7 tasks done
@pablogsal
pythongh-111201: Allow bracketed paste to work
4315668
@pablogsal
pablogsal force-pushed the enable_bracketed_paste branch from e438388 to 4315668 Compare May 7, 2024 11:52
@pablogsal
pablogsal requested review from hauntsaninja and hugovk May 7, 2024 11:55
@pablogsal pablogsal added the skip news label May 7, 2024
@pablogsal
pablogsal requested a review from ambv May 7, 2024 11:56
lysnikolaou
lysnikolaou reviewed May 7, 2024
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nitty comments. Feel free to merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/_pyrepl/commands.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/_pyrepl/simple_interact.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal added 3 commits May 7, 2024 13:17
@pablogsal
fixup! pythongh-111201: Allow bracketed paste to work
9a72159
@pablogsal
fixup! fixup! pythongh-111201: Allow bracketed paste to work
ec72176
@pablogsal
fixup! fixup! fixup! pythongh-111201: Allow bracketed paste to work
75222d1
@pablogsal

pablogsal commented May 7, 2024

Copy link
Copy Markdown
Member Author

CC: @Yhg1s
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
fixup! fixup! fixup! fixup! pythongh-111201: Allow bracketed paste to…
78ce02b 
… work
ambv
ambv approved these changes May 7, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 7, 2024
lysnikolaou
lysnikolaou approved these changes May 7, 2024
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one more nitty comment.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/_pyrepl/unix_console.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv enabled auto-merge (squash) May 7, 2024 12:26
@pablogsal
fixup! fixup! fixup! fixup! fixup! pythongh-111201: Allow bracketed p…
c0cd485 
…aste to work
@ambv
ambv merged commit 7d90b8a into python:main May 7, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 7, 2024
@pablogsal
pablogsal deleted the enable_bracketed_paste branch May 7, 2024 12:55
@hauntsaninja

hauntsaninja commented May 7, 2024

Copy link
Copy Markdown
Contributor

Amazing! I love living in this synthwave future
pablogsal and ambv reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@pablogsal @SonicField
pythongh-111201: Allow bracketed paste to work (pythonGH-118700)
7e72daa
cfbolz added a commit to pypy/pypy that referenced this pull request Jul 29, 2024
@cfbolz
implement bracketed paste in pyrepl
15699e9 
as far as I'm aware this should make gh-2880 go away (not 100% sure,
don't have a mac to test).

backport of parts of python/cpython#118700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv approved these changes
@lysnikolaou lysnikolaou lysnikolaou approved these changes
@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja
@hugovk hugovk Awaiting requested review from hugovk

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pablogsal @hauntsaninja @ambv @lysnikolaou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.