GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix some missing null checks. by zooba · Pull Request #118721 · python/cpython

Conversation

@zooba

@zooba zooba commented May 7, 2024

Copy link
Copy Markdown
Member

Very minor fixes, found by static analysis

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
Fix some missing null checks.
7535f42
@zooba zooba added skip issue skip news labels May 7, 2024
@zooba
zooba requested review from a team and markshannon as code owners May 7, 2024 16:25
@bedevere-app bedevere-app Bot added the awaiting core review label May 7, 2024
colesbury
colesbury reviewed May 7, 2024
View reviewed changes
Comment thread Objects/typeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@zooba
Invert test
e4c3765
@zooba
zooba merged commit 7e6fcab into python:main May 10, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label May 10, 2024
@zooba
zooba deleted the analysisfixes branch May 10, 2024 09:31
@zooba zooba added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 10, 2024
@miss-islington-app

miss-islington-app Bot commented May 10, 2024

Copy link
Copy Markdown

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented May 10, 2024

Copy link
Copy Markdown

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2024
@zooba @miss-islington
Fix some missing null checks. (pythonGH-118721)
fd6dcf8 
(cherry picked from commit 7e6fcab)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-app

bedevere-app Bot commented May 10, 2024

Copy link
Copy Markdown

GH-118885 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 10, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2024
@zooba @miss-islington
Fix some missing null checks. (pythonGH-118721)
fce9a26 
(cherry picked from commit 7e6fcab)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-app

bedevere-app Bot commented May 10, 2024

Copy link
Copy Markdown

GH-118886 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 10, 2024
zooba added a commit that referenced this pull request May 10, 2024
@miss-islington @zooba
Fix some missing null checks. (GH-118721)
8bfaf3a 
(cherry picked from commit 7e6fcab)

Co-authored-by: Steve Dower <[email protected]>
zooba added a commit that referenced this pull request May 10, 2024
@miss-islington @zooba
Fix some missing null checks. (GH-118721)
d524802 
(cherry picked from commit 7e6fcab)

Co-authored-by: Steve Dower <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury left review comments
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@zooba @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.