GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] gh-118486: Support mkdir(mode=0o700) on Windows (GH-118488) by zooba · Pull Request #118742 · python/cpython

Conversation

@zooba

@zooba zooba commented May 7, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: [CVE-2024-4030] Enable mkdir(mode=0o700) to work on Windows #118486

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
pythongh-118486: Support mkdir(mode=0o700) on Windows
86da8de
@bedevere-app bedevere-app Bot added the awaiting core review label May 7, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 7, 2024
[CVE-2024-4030] Enable mkdir(mode=0o700) to work on Windows #118486
Closed
zooba
zooba commented May 7, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.8.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Security/2024-05-01-20-57-09.gh-issue-118486.K44KJG.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.8.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@zooba
Fix CVE in docs
3f5e5f5
@zooba zooba changed the title [3.8] gh-118486: Support mkdir(mode=0o700) on Windows (GH-118488] [3.8] gh-118486: Support mkdir(mode=0o700) on Windows (GH-118488) May 7, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 7, 2024
gh-118486: Support mkdir(mode=0o700) on Windows #118488
Merged
zooba
zooba commented May 7, 2024
View reviewed changes
Comment thread Lib/test/test_os.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_tempfile.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@zooba
Apply suggestions from code review
f7dd957
@zooba

zooba commented May 7, 2024

Copy link
Copy Markdown
Member Author

macOS failure is unrelated: configure: error: C compiler cannot create executables
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou added the type-security A security issue label May 8, 2024
@zooba zooba added the DO-NOT-MERGE label May 9, 2024
@zooba
Use language-invariant ACL
0069b38
@zooba zooba removed the DO-NOT-MERGE label May 9, 2024
@zooba

zooba commented May 9, 2024

Copy link
Copy Markdown
Member Author

macOS failure is still unrelated
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented May 14, 2024

Copy link
Copy Markdown
Member Author

Should include #119056 before merging (I'll backport it).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zooba and others added 2 commits May 15, 2024 12:02
@zooba
pythongh-118486: Simplify test_win32_mkdir_700 to check the exact ACL (…
c4b3f7a 
…pythonGH-119056)
@ambv
Merge branch '3.8' into pythongh-118486-3.8
18afc1f
@ambv
ambv merged commit 91e3669 into python:3.8 May 24, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label May 24, 2024
@zooba
zooba deleted the gh-118486-3.8 branch June 26, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@zooba @ambv @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.