GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118486: Simplify test_win32_mkdir_700 to check the exact ACL by zooba · Pull Request #119056 · python/cpython

Conversation

@zooba

@zooba zooba commented May 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: [CVE-2024-4030] Enable mkdir(mode=0o700) to work on Windows #118486

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Aein29 reacted with eyes emoji
All reactions
  • 👀 1 reaction
@zooba
pythongh-118486: Simplify test_win32_mkdir_700 to check the exact ACL
f6ec3b1
@zooba zooba added tests Tests in the Lib/test dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels May 14, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label May 14, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 14, 2024
[CVE-2024-4030] Enable mkdir(mode=0o700) to work on Windows #118486
Closed
@zooba

zooba commented May 14, 2024

Copy link
Copy Markdown
Member Author

!buildbot .windows.

Aein29 reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented May 14, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zooba for commit f6ec3b1 🤖

The command will test the builders whose names match following regular expression: .*windows.*

The builders matched are:

  • AMD64 Windows11 Non-Debug PR
  • AMD64 Windows11 Refleaks PR
  • AMD64 Windows Server 2022 NoGIL PR
  • ARM64 Windows PR
  • ARM64 Windows Non-Debug PR
  • AMD64 Windows10 PR
  • AMD64 Windows11 Bigmem PR
Aein29 reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced May 14, 2024
[3.11] gh-118486: Support mkdir(mode=0o700) on Windows (GH-118488) #118739
Merged
[3.10] gh-118486: Support mkdir(mode=0o700) on Windows (GH-118488) #118740
Merged
[3.9] gh-118486: Support mkdir(mode=0o700) on Windows (GH-118488) #118741
Merged
[3.8] gh-118486: Support mkdir(mode=0o700) on Windows (GH-118488) #118742
Merged
@zooba

zooba commented May 15, 2024

Copy link
Copy Markdown
Member Author

Failures are unrelated.

Aein29 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba
zooba merged commit 94591dc into python:main May 15, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label May 15, 2024
@miss-islington-app

miss-islington-app Bot commented May 15, 2024

Copy link
Copy Markdown

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba
zooba deleted the gh-118486 branch May 15, 2024 10:59
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 15, 2024
@zooba @miss-islington
pythongh-118486: Simplify test_win32_mkdir_700 to check the exact ACL (…
4b6d638
…pythonGH-119056)

(cherry picked from commit 94591dc)

Co-authored-by: Steve Dower <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 15, 2024
@zooba @miss-islington
pythongh-118486: Simplify test_win32_mkdir_700 to check the exact ACL (…
1da9d7d
…pythonGH-119056)

(cherry picked from commit 94591dc)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-app

bedevere-app Bot commented May 15, 2024

Copy link
Copy Markdown

GH-119068 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 15, 2024
@bedevere-app

bedevere-app Bot commented May 15, 2024

Copy link
Copy Markdown

GH-119069 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 15, 2024
zooba added a commit to zooba/cpython that referenced this pull request May 15, 2024
@zooba
pythongh-118486: Simplify test_win32_mkdir_700 to check the exact ACL (…
e598a53
…pythonGH-119056)
zooba added a commit to zooba/cpython that referenced this pull request May 15, 2024
@zooba
pythongh-118486: Simplify test_win32_mkdir_700 to check the exact ACL (…
77ede7c
…pythonGH-119056)
zooba added a commit to zooba/cpython that referenced this pull request May 15, 2024
@zooba
pythongh-118486: Simplify test_win32_mkdir_700 to check the exact ACL (…
1946e26
…pythonGH-119056)
zooba added a commit to zooba/cpython that referenced this pull request May 15, 2024
@zooba
pythongh-118486: Simplify test_win32_mkdir_700 to check the exact ACL (…
c4b3f7a
…pythonGH-119056)
zooba added a commit that referenced this pull request May 15, 2024
@miss-islington @zooba
gh-118486: Simplify test_win32_mkdir_700 to check the exact ACL (GH-1…
e1dfa97
…19056)

(cherry picked from commit 94591dc)

Co-authored-by: Steve Dower <[email protected]>
zooba added a commit that referenced this pull request May 15, 2024
@miss-islington @zooba
gh-118486: Simplify test_win32_mkdir_700 to check the exact ACL (GH-1…
6d0850c
…19056)

(cherry picked from commit 94591dc)

Co-authored-by: Steve Dower <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@zooba @estyxx
pythongh-118486: Simplify test_win32_mkdir_700 to check the exact ACL (…
26483c7
…pythonGH-119056)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@zooba @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.