GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Format None, True, False and NotImplemented as literals by serhiy-storchaka · Pull Request #118758 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 8, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

📚 Documentation preview 📚: https://cpython-previews--118758.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
Format None, True, False and NotImplemented as literals
1cbc88d
@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir skip issue skip news needs backport to 3.12 only security fixes labels May 8, 2024
@serhiy-storchaka
serhiy-storchaka requested review from a team, 1st1, AlexWaygood, JelleZijlstra, asvetlov, barneygale, brettcannon, ericsnowcurrently, ericvsmith, gpshead, gvanrossum, kumaraditya303, ncoghlan, pablogsal, rhettinger, vsajip, warsaw and willingc as code owners May 8, 2024 09:31
@bedevere-app bedevere-app Bot added the awaiting core review label May 8, 2024
AlexWaygood
AlexWaygood reviewed May 8, 2024
View reviewed changes
Comment thread Misc/NEWS.d/3.11.0b1.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/3.12.0a1.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/3.13.0a1.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/3.13.0a2.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rhettinger
rhettinger removed request for a team and rhettinger May 8, 2024 15:12
rhettinger
rhettinger approved these changes May 8, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 8, 2024
JelleZijlstra
JelleZijlstra reviewed May 8, 2024
View reviewed changes
Comment thread Doc/c-api/object.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka @JelleZijlstra @AlexWaygood
Apply suggestions from code review
3cdb8d9 
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@serhiy-storchaka
serhiy-storchaka merged commit 05c2fe1 into python:main May 8, 2024
@miss-islington-app

miss-islington-app Bot commented May 8, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 8, 2024
@serhiy-storchaka
serhiy-storchaka deleted the docs-none-literal branch May 8, 2024 19:35
@miss-islington-app

miss-islington-app Bot commented May 8, 2024

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 05c2fe1acda9ea5a57061642c36e8b73bb4fbba4 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned serhiy-storchaka May 8, 2024
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 only security fixes label May 8, 2024
@miss-islington-app

miss-islington-app Bot commented May 8, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2024
@serhiy-storchaka @miss-islington
Format None, True, False and NotImplemented as literals (pythonGH-118758
1ee2c7b 
)

(cherry picked from commit 05c2fe1)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented May 8, 2024

Copy link
Copy Markdown

GH-118792 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 8, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request May 8, 2024
@serhiy-storchaka
Format None, True, False and NotImplemented as literals (pythonGH-118758
392bd67 
)

(cherry picked from commit 05c2fe1)
@bedevere-app

bedevere-app Bot commented May 8, 2024

Copy link
Copy Markdown

GH-118794 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 8, 2024
serhiy-storchaka added a commit that referenced this pull request May 8, 2024
@miss-islington @serhiy-storchaka
[3.13] Format None, True, False and NotImplemented as literals (GH-11…
8f31af6 
…8758) (GH-118792)

(cherry picked from commit 05c2fe1)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request May 8, 2024
@serhiy-storchaka
[3.12] Format None, True, False and NotImplemented as literals (GH-11…
530c3bb 
…8758) (GH-118794)

(cherry picked from commit 05c2fe1)
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
@AlexWaygood AlexWaygood AlexWaygood left review comments
@rhettinger rhettinger rhettinger approved these changes
@barneygale barneygale Awaiting requested review from barneygale barneygale is a code owner
@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@brettcannon brettcannon Awaiting requested review from brettcannon
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently
@ncoghlan ncoghlan Awaiting requested review from ncoghlan
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@serhiy-storchaka @JelleZijlstra @rhettinger @gvanrossum @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.