GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118772: Allow TypeVars without a default to follow those with a default when constructing aliases by JelleZijlstra · Pull Request #118774 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 8, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Relax TypeVar default ordering constraints #118772

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JelleZijlstra added 2 commits May 8, 2024 09:15
@JelleZijlstra
Relax defaults
4e6fdb3
@JelleZijlstra
blurb
8ee213b
@JelleZijlstra JelleZijlstra added the needs backport to 3.13 only security fixes label May 8, 2024
@JelleZijlstra
JelleZijlstra requested a review from AlexWaygood as a code owner May 8, 2024 16:23
@bedevere-app bedevere-app Bot added the awaiting core review label May 8, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 8, 2024
Relax TypeVar default ordering constraints #118772
Closed
AlexWaygood
AlexWaygood approved these changes May 8, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 8, 2024
@JelleZijlstra
JelleZijlstra merged commit aac6b01 into python:main May 8, 2024
@miss-islington-app

miss-islington-app Bot commented May 8, 2024

Copy link
Copy Markdown

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 8, 2024
@JelleZijlstra
JelleZijlstra deleted the relaxdefailt branch May 8, 2024 16:54
@bedevere-app

bedevere-app Bot commented May 8, 2024

Copy link
Copy Markdown

GH-118776 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 8, 2024
JelleZijlstra added a commit that referenced this pull request May 8, 2024
@miss-islington @JelleZijlstra
[3.13] gh-118772: Allow TypeVars without a default to follow those wi…
c6680cd 
…th a default when constructing aliases (GH-118774) (#118776)

(cherry picked from commit aac6b01)

Co-authored-by: Jelle Zijlstra <[email protected]>
@AlexWaygood

AlexWaygood commented May 13, 2024

Copy link
Copy Markdown
Member

Unfortunately I think it's infeasible to backport this to typing_extensions, unless we can think of some other approach to implement the same behaviour at typing_extensions. Here's the beginnings of a typing_extensions patch: https://github.com/python/typing_extensions/compare/main...AlexWaygood:typing_extensions:646-default-before-nondefault?expand=1. It passes tests on Python 3.11 and 3.12, but starts interfering with the typing.py internals in some quite fundamental ways on lower versions of Python due to the extensiveness of the monkeypatching. It's plausibly fixable, but it would require even more invasive monkeypatching, and I think it would make the code too fragile.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood mentioned this pull request May 14, 2024
Allow type parameters without default values to follow those with default values in some situations python/typing_extensions#392
Merged
@AlexWaygood

AlexWaygood commented May 14, 2024

Copy link
Copy Markdown
Member

Alright, here we go... python/typing_extensions#392
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
@JelleZijlstra
JelleZijlstra restored the relaxdefailt branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.