GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118760: Restore the default value of tkinter.wantobjects to 1 by serhiy-storchaka · Pull Request #118784 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 8, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It was set to 2 in 65f5e58 (GH-98592).

  • Issue: Tkinter getint(), getboolean() argument must be str, not tuple #118760

📚 Documentation preview 📚: https://cpython-previews--118784.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-118760: Restore the default value of tkiter.wantobjects to 1
a65789b 
It was set to 2 in 65f5e58 (pythonGH-98592).
@serhiy-storchaka serhiy-storchaka added release-blocker needs backport to 3.13 only security fixes labels May 8, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label May 8, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 8, 2024
Tkinter getint(), getboolean() argument must be str, not tuple #118760
Closed
@Eclips4 Eclips4 changed the title gh-118760: Restore the default value of tkiter.wantobjects to 1 gh-118760: Restore the default value of tkinter.wantobjects to 1 May 8, 2024
terryjreedy
terryjreedy reviewed May 8, 2024
View reviewed changes
Comment thread Misc/NEWS.d/3.13.0b1.rst Outdated
Add support for passing arguments to callbacks registered in the :mod:`tkinter`
module as various Python objects (``int``, ``float``, ``bytes``, ``tuple``),
corresponding to the original Tcl value, not just ``str``, and enable this by default.
To restore the previous behavior set :mod:`!tkinter` module global

@terryjreedy terryjreedy May 8, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not make sense when the value already is 1.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@serhiy-storchaka serhiy-storchaka May 8, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is an edited NEWS entry for 3.13.0b1.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@terryjreedy terryjreedy May 8, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to 3.13 what's new suggests that the change to wantobjects will be backported also. 'Restoring' 1 to 1 is what I questioned.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@serhiy-storchaka serhiy-storchaka May 15, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an edited NEWS entry for 3.13.0b1. We cannot simply remove it, because it is the part of the history, and 3.13.0b1 was already released with the bug.

But I reworded it, focusing on the possibility to change the behavior and adding that it was changed by default (not for long, for 3.13.0b1 only). So "restoring" here refers to the changed default. How to write this better? Maybe just remove all starting from "To restore"? And add the description of how to enable the experimental feature in the new NEWS entry for 3.13.0b2?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
Other attempt.
77e2758
@serhiy-storchaka
serhiy-storchaka merged commit e188527 into python:main May 20, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label May 20, 2024
@miss-islington-app

miss-islington-app Bot commented May 20, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka deleted the tkinter-wantobject-1 branch May 20, 2024 19:21
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
@serhiy-storchaka @miss-islington
pythongh-118760: Restore the default value of tkinter.wantobjects to 1 (
1b00598 
pythonGH-118784)

It was set to 2 in 65f5e58 (pythonGH-98592).
(cherry picked from commit e188527)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented May 20, 2024

Copy link
Copy Markdown

GH-119251 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 20, 2024
serhiy-storchaka added a commit that referenced this pull request May 20, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-118760: Restore the default value of tkinter.wantobjects to…
b4462aa 
… 1 (GH-118784) (GH-119251)

It was set to 2 in 65f5e58 (GH-98592).
(cherry picked from commit e188527)

Co-authored-by: Serhiy Storchaka <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@serhiy-storchaka @estyxx
pythongh-118760: Restore the default value of tkinter.wantobjects to 1 (
6b5ad2c 
pythonGH-118784)

It was set to 2 in 65f5e58 (pythonGH-98592).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

release-blocker

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @terryjreedy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.