GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118773: Use language-invariant SDDL string instead of aliases for ACLs. by zooba · Pull Request #118800 · python/cpython

Conversation

@zooba

@zooba zooba commented May 8, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: tempfile.mkdtemp and pip fail on non-English Windows with 3.13.0b1 #118773

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
stonebig reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@zooba
pythongh-118773: Use well-known constants instead of aliases for ACLs.
25afdd7
@bedevere-app bedevere-app Bot added the awaiting core review label May 8, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 8, 2024
tempfile.mkdtemp and pip fail on non-English Windows with 3.13.0b1 #118773
Closed
@Eclips4 Eclips4 added the needs backport to 3.13 only security fixes label May 8, 2024
@Eclips4 Eclips4 mentioned this pull request May 9, 2024
test_os fails on Windows #118802
Closed
@zooba
Switch to SDDL string
99ae180
@zooba zooba changed the title gh-118773: Use well-known constants instead of aliases for ACLs. gh-118773: Use language-invariant SDDL string instead of aliases for ACLs. May 9, 2024
@zooba

zooba commented May 9, 2024

Copy link
Copy Markdown
Member Author

!buildbot .windows.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 9, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zooba for commit 99ae180 🤖

The command will test the builders whose names match following regular expression: .*windows.*

The builders matched are:

  • AMD64 Windows11 Non-Debug PR
  • AMD64 Windows11 Refleaks PR
  • AMD64 Windows Server 2022 NoGIL PR
  • ARM64 Windows PR
  • ARM64 Windows Non-Debug PR
  • AMD64 Windows10 PR
  • AMD64 Windows11 Bigmem PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented May 9, 2024

Copy link
Copy Markdown
Member Author

FYI, this will be backported to all branches, but because the original change hasn't been merged into those yet it can't be done automatically. I'll handle it myself once this one is reviewed and merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented May 9, 2024

Copy link
Copy Markdown
Member Author

The test_cext failure on ARM64 is unrelated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
eryksun
eryksun reviewed May 9, 2024
View reviewed changes
Comment thread Modules/posixmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
eryksun
eryksun reviewed May 9, 2024
View reviewed changes
Comment thread Modules/posixmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@zooba
Review feedback
9216aa3
@zooba
zooba merged commit 8af84b5 into python:main May 9, 2024
@miss-islington-app

miss-islington-app Bot commented May 9, 2024

Copy link
Copy Markdown

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label May 9, 2024
@zooba
zooba deleted the gh-118773 branch May 9, 2024 16:43
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
@zooba @miss-islington
pythongh-118773: Use language-invariant SDDL string instead of aliase…
571459f 
…s for ACLs. (pythonGH-118800)

(cherry picked from commit 8af84b5)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-app

bedevere-app Bot commented May 9, 2024

Copy link
Copy Markdown

GH-118858 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 9, 2024
zooba added a commit that referenced this pull request May 9, 2024
@miss-islington @zooba
gh-118773: Use language-invariant SDDL string instead of aliases for …
9d646d0 
…ACLs. (GH-118800)

(cherry picked from commit 8af84b5)

Co-authored-by: Steve Dower <[email protected]>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
@zooba @SonicField
pythongh-118773: Use language-invariant SDDL string instead of aliase…
a6bc4e3 
…s for ACLs. (pythonGH-118800)
@arhadthedev arhadthedev mentioned this pull request May 12, 2024
Use language-invariant SDDL string instead of aliases for ACLs arhadthedev/embedded-ecmascript#73
Open
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eryksun eryksun eryksun left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zooba @bedevere-bot @eryksun @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.