GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [tests]: Mark ``test_statistics.test_kde_random`` with a ``requires_resource('cpu')`` decorator by Eclips4 · Pull Request #118801 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented May 8, 2024

Copy link
Copy Markdown
Member

This is a CPU-intensive test. On my machine (Ryzen 7 4800H, 8/16), it takes about 80 seconds.

./python -m test -v test_statistics -m test_kde_random
== CPython 3.14.0a0 (heads/main:cb6f75a32c, May 8 2024, 23:39:14) [GCC 9.4.0]
== Linux-5.10.16.3-microsoft-standard-WSL2-x86_64-with-glibc2.31 little-endian
== Python build: free_threading debug
== cwd: /home/eclips4/CLionProjects/cpython/build/test_python_worker_26032æ
== CPU count: 16
== encodings: locale=UTF-8 FS=utf-8
== resources: all test resources are disabled, use -u option to unskip tests

Using random seed: 1617172693
0:00:00 load avg: 0.15 Run 1 test sequentially
0:00:00 load avg: 0.15 [1/1] test_statistics
test_kde_random (test.test_statistics.TestKDE.test_kde_random) ... ok

----------------------------------------------------------------------
Ran 1 test in 80.244s

OK
test_statistics passed in 1 min 20 sec

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1 min 20 sec
Total tests: run=1 (filtered)
Total test files: run=1/1 (filtered)
Result: SUCCESS

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Eclips4
Mark test_kde_random with a requires_resource('cpu') decorator
3bd8a5a
@Eclips4 Eclips4 added skip issue skip news labels May 8, 2024
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels May 8, 2024
@Eclips4 Eclips4 added the needs backport to 3.13 only security fixes label May 8, 2024
@Eclips4 Eclips4 changed the title [tests]: Mark `test_statistics.test_kde_random with a requires_resource('cpu') decorator [tests]: Mark test_statistics.test_kde_random with a requires_resource('cpu') decorator May 8, 2024
JelleZijlstra
JelleZijlstra approved these changes May 8, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 8, 2024
sobolevn
sobolevn approved these changes May 9, 2024
View reviewed changes
@sobolevn
sobolevn merged commit 027e6d8 into python:main May 9, 2024
@miss-islington-app

miss-islington-app Bot commented May 9, 2024

Copy link
Copy Markdown

Thanks @Eclips4 for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 9, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
@Eclips4 @miss-islington
[tests]: Mark test_statistics.test_kde_random with a ``requires_r…
97f8089 
…esource('cpu')`` decorator (pythonGH-118801)

Mark test_kde_random with a requires_resource('cpu') decorator
(cherry picked from commit 027e6d8)

Co-authored-by: Kirill Podoprigora <[email protected]>
@bedevere-app

bedevere-app Bot commented May 9, 2024

Copy link
Copy Markdown

GH-118818 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 9, 2024
@sobolevn

sobolevn commented May 9, 2024

Copy link
Copy Markdown
Member

What about 3.12 backport?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4

Eclips4 commented May 9, 2024

Copy link
Copy Markdown
Member Author

What about 3.12 backport?

This test was not backported to the 3.12 branch, so there is no need to backport it there.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4
Eclips4 deleted the decorator_for_kde_random branch May 9, 2024 08:24
@bedevere-bot

bedevere-bot commented May 9, 2024

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD14 3.x has failed when building commit 027e6d8.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1232/builds/2294) and take a look at the build logs.
  4. Check if the failure is related to this commit (027e6d8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1232/builds/2294

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/threading.py", line 1039, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/threading.py", line 990, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/test_interpreters/test_stress.py", line 29, in task
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k


Traceback (most recent call last):
  File "<frozen getpath>", line 355, in <module>
ValueError: embedded null byte
Warning -- Uncaught thread exception: InterpreterError
Exception in thread Thread-124 (task):
RuntimeError: error evaluating path
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4 Eclips4 mentioned this pull request May 9, 2024
New buildbot failure: interpreters.InterpreterError: interpreter creation failed #118823
Closed
@Eclips4

Eclips4 commented May 9, 2024

Copy link
Copy Markdown
Member Author

Buildbot failure is unrelated; I've created #118823 to track this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn pushed a commit that referenced this pull request May 9, 2024
@miss-islington @Eclips4
[3.13] [tests]: Mark test_statistics.test_kde_random with a ``req…
09896fc 
…uires_resource('cpu')`` decorator (GH-118801) (#118818)

[tests]: Mark ``test_statistics.test_kde_random`` with a ``requires_resource('cpu')`` decorator (GH-118801)

Mark test_kde_random with a requires_resource('cpu') decorator
(cherry picked from commit 027e6d8)

Co-authored-by: Kirill Podoprigora <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
@Eclips4 Eclips4 mentioned this pull request Jun 16, 2024
gh-120560: Mark zip64 tests in test_zipimport as cpu-heavy #120564
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@sobolevn sobolevn sobolevn approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Eclips4 @sobolevn @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.