GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118803: Remove `ByteString` from `typing` and `collections.abc` by sobolevn · Pull Request #118804 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented May 8, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Remove ByteString from typing and collections.abc #118803

📚 Documentation preview 📚: https://cpython-previews--118804.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sobolevn
pythongh-118803: Remove ByteString from typing and collections.abc
7cf1579
@sobolevn
sobolevn requested review from AlexWaygood, JelleZijlstra and rhettinger as code owners May 8, 2024 21:53
@bedevere-app bedevere-app Bot added the awaiting core review label May 8, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 8, 2024
Remove ByteString from typing and collections.abc #118803
Closed
rhettinger
rhettinger approved these changes May 8, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 8, 2024
@sobolevn
Fix CI
071fd88
JelleZijlstra
JelleZijlstra approved these changes May 8, 2024
View reviewed changes
AlexWaygood
AlexWaygood approved these changes May 8, 2024
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Lib/typing.py
return Union[left, self]


class _DeprecatedGenericAlias(_SpecialGenericAlias, _root=True):

@AlexWaygood AlexWaygood May 8, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need this again in the future. But I guess it's pretty easy to add it back if/when that happens

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@AlexWaygood
AlexWaygood merged commit 2f4db5a into python:main May 8, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 8, 2024
@cdce8p

cdce8p commented May 26, 2025

Copy link
Copy Markdown
Contributor

Left a longer comment on the issue but to summarize I was a bit surprised to discover that just importing typing.ByteString didn't seem to create a DeprecationWarning in 3.13.

#118803 (comment)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Sep 16, 2025
@AlexWaygood
Revert "pythongh-118803: Remove ByteString from typing and `colle…
850c179
…ctions.abc` (python#118804)"

This reverts commit 2f4db5a.
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Sep 16, 2025
@AlexWaygood
Revert "pythongh-118803: Remove ByteString from typing and `colle…
be5d2e6
…ctions.abc` (python#118804)"

This reverts commit 2f4db5a.
@AlexWaygood AlexWaygood mentioned this pull request Sep 16, 2025
Revert "gh-118803: Remove ByteString from typing and collections.abc (#118804)" #138990
Merged
AlexWaygood added a commit that referenced this pull request Sep 16, 2025
@AlexWaygood
Revert "gh-118803: Remove ByteString from typing and `collections…
530ddd3
….abc` (#118804)" (#138990)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2025
@AlexWaygood @miss-islington
Revert "pythongh-118803: Remove ByteString from typing and `colle…
997a9b9
…ctions.abc` (pythonGH-118804)" (pythonGH-138990)

(cherry picked from commit 530ddd3)

Co-authored-by: Alex Waygood <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 16, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO 3.x (tier-3) has failed when building commit 530ddd3.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/567/builds/10135) and take a look at the build logs.
  4. Check if the failure is related to this commit (530ddd3) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/567/builds/10135

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto/build/Lib/contextlib.py", line 112, in __init__
    doc = getattr(func, "__doc__", None)
ValueError: flush of closed file
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.BufferedWriter>:
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.lto/build/Lib/contextlib.py", line 112, in __init__
    doc = getattr(func, "__doc__", None)
ValueError: flush of closed file
k
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk pushed a commit that referenced this pull request Sep 17, 2025
@miss-islington @AlexWaygood
[3.14] Revert "gh-118803: Remove ByteString from typing and `coll…
7bba99c
…ections.abc` (GH-118804)" (GH-138990) (#138995)

Revert "gh-118803: Remove `ByteString` from `typing` and `collections.abc` (GH-118804)" (GH-138990)
(cherry picked from commit 530ddd3)

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@rhettinger rhettinger rhettinger approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sobolevn @cdce8p @bedevere-bot @JelleZijlstra @rhettinger @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.