GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118805: Remove type, choices, metavar params of `BooleanOptionalAction` by sobolevn · Pull Request #118806 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented May 8, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Remove type, choices, and metavar parameters of argparse.BooleanOptionalAction #118805

📚 Documentation preview 📚: https://cpython-previews--118806.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-118805: Remove type, choices, metavar params of `BooleanOpti…
3ed730b 
…onalAction`
@bedevere-app bedevere-app Bot added the awaiting core review label May 8, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 8, 2024
Remove type, choices, and metavar parameters of argparse.BooleanOptionalAction #118805
Closed
@sobolevn sobolevn changed the title gh-118805: Remove type, choices, metavar params of `BooleanOptionalAc… gh-118805: Remove type, choices, metavar params of BooleanOptionalAction May 8, 2024
@sobolevn
sobolevn requested a review from AlexWaygood May 9, 2024 08:04
@sobolevn
Merge branch 'main' into issue-118805
c2009e5
AlexWaygood
AlexWaygood approved these changes May 9, 2024
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Library/2024-05-09-01-05-52.gh-issue-118805.N7dm07.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2024-05-09-01-05-52.gh-issue-118805.N7dm07.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 9, 2024
sobolevn and others added 2 commits May 9, 2024 12:44
@sobolevn @AlexWaygood
Apply suggestions from code review
7e2f399 
Co-authored-by: Alex Waygood <[email protected]>
@sobolevn
Merge branch 'main' into issue-118805
752256c
@sobolevn
sobolevn enabled auto-merge (squash) May 9, 2024 09:46
hugovk
hugovk reviewed May 9, 2024
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Address review
3109daf
@sobolevn
sobolevn merged commit da090f1 into python:main May 9, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 9, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 9, 2024
@sobolevn @AlexWaygood @SonicField
pythongh-118805: Remove type, choices, metavar params of `BooleanOpti…
ad9821d 
…onalAction` (python#118806)

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @hugovk @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.