GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117657: Acquire a critical section around `SemLock.__{enter,exit}__` by mpage · Pull Request #118812 · python/cpython

Conversation

@mpage

@mpage mpage commented May 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

These methods are purely wrappers around Semlock.{acquire,release}, which expect a critical section to be held.

Sample race reported by TSAN.

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mpage
Acquire a critical section around SemLock.__{enter,exit}__
8f38bc2 
These methods are purely wrappers around `Semlock.{acquire,release}`,
which expect a critical section to be held.
@mpage mpage added the skip news label May 9, 2024
@mpage
mpage requested a review from colesbury May 9, 2024 00:08
@bedevere-app bedevere-app Bot mentioned this pull request May 9, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
@mpage
mpage marked this pull request as ready for review May 9, 2024 00:48
@mpage
mpage requested a review from gpshead as a code owner May 9, 2024 00:48
@bedevere-app bedevere-app Bot added the awaiting review label May 9, 2024
@colesbury colesbury added the needs backport to 3.13 only security fixes label May 9, 2024
colesbury
colesbury approved these changes May 9, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 9, 2024
@colesbury
colesbury merged commit c30d8e5 into python:main May 9, 2024
@miss-islington-app

miss-islington-app Bot commented May 9, 2024

Copy link
Copy Markdown

Thanks @mpage for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 9, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
@mpage @miss-islington
pythongh-117657: Acquire a critical section around `SemLock.__{enter,…
46aa7ef 
…exit}__` (pythonGH-118812)

These methods are purely wrappers around `Semlock.{acquire,release}`,
which expect a critical section to be held.
(cherry picked from commit c30d8e5)

Co-authored-by: mpage <[email protected]>
@bedevere-app

bedevere-app Bot commented May 9, 2024

Copy link
Copy Markdown

GH-118856 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 9, 2024
colesbury pushed a commit that referenced this pull request May 9, 2024
@miss-islington @mpage
[3.13] gh-117657: Acquire a critical section around `SemLock.__{enter…
62a559a 
…,exit}__` (GH-118812) (#118856)

These methods are purely wrappers around `Semlock.{acquire,release}`,
which expect a critical section to be held.
(cherry picked from commit c30d8e5)

Co-authored-by: mpage <[email protected]>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
@mpage @SonicField
pythongh-117657: Acquire a critical section around `SemLock.__{enter,…
154a3f5 
…exit}__` (python#118812)

These methods are purely wrappers around `Semlock.{acquire,release}`,
which expect a critical section to be held.
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mpage @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.