GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118767: Improve tests and docs for bool(NotImplemented) by JelleZijlstra · Pull Request #118813 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Followup from #118775 (comment)

📚 Documentation preview 📚: https://cpython-previews--118813.org.readthedocs.build/

  • Issue: Make bool(NotImplemented) into an error #118767

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JelleZijlstra added 2 commits May 8, 2024 17:12
@JelleZijlstra
pythongh-118775: Improve tests and docs for bool(NotImplemented)
46d29c4
@JelleZijlstra
Use the GitHub issue number, not the bpo one
6c53cbf
@JelleZijlstra
JelleZijlstra requested a review from serhiy-storchaka May 9, 2024 00:14
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels May 9, 2024
@JelleZijlstra JelleZijlstra added the skip news label May 9, 2024
@JelleZijlstra JelleZijlstra changed the title gh-118775: Improve tests and docs for bool(NotImplemented) gh-118767: Improve tests and docs for bool(NotImplemented) May 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 9, 2024
Make bool(NotImplemented) into an error #118767
Closed
serhiy-storchaka
serhiy-storchaka approved these changes May 9, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It is much better now.

I think that the NEWS entry contains a redundant link.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 9, 2024
@JelleZijlstra
Remove redundant link in NEWS
1c52b57
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) May 9, 2024 13:22
@JelleZijlstra
JelleZijlstra merged commit 35b5eaa into python:main May 9, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label May 9, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 9, 2024
@JelleZijlstra @SonicField
pythongh-118767: Improve tests and docs for bool(NotImplemented) (pyt…
a657dd5 
…hon#118813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.