GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118817: Fix `asyncio REPL` on Windows by Eclips4 · Pull Request #118819 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented May 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: asyncio REPL is not working on Windows #118817

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
stonebig reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@Eclips4
Fix asyncio REPL on Windows
71cd972
@Eclips4 Eclips4 added the skip news label May 9, 2024
@Eclips4
Eclips4 requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners May 9, 2024 08:16
@bedevere-app bedevere-app Bot added the awaiting review label May 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 9, 2024
asyncio REPL is not working on Windows #118817
Closed
@Eclips4
Eclips4 removed request for 1st1, asvetlov and kumaraditya303 May 9, 2024 08:17
Eclips4
Eclips4 commented May 9, 2024
View reviewed changes
Comment thread Lib/test/test_repl.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4
Remove accidentally added newline
ebedccf
@Eclips4 Eclips4 added 3.13 only security fixes needs backport to 3.13 only security fixes and removed 3.13 only security fixes labels May 9, 2024
@Eclips4
Remove accidentally added tab...
729d11e
sobolevn
sobolevn approved these changes May 9, 2024
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me!

CC @ambv

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 9, 2024
gvanrossum
gvanrossum approved these changes May 9, 2024
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
gvanrossum merged commit c3643a1 into python:main May 9, 2024
@miss-islington-app

miss-islington-app Bot commented May 9, 2024

Copy link
Copy Markdown

Thanks @Eclips4 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 9, 2024
@Eclips4
Eclips4 deleted the fix-asyncio-repl branch May 9, 2024 15:20
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
@Eclips4 @miss-islington
pythongh-118817: Fix asyncio REPL on Windows (pythonGH-118819)
89cc421 
(cherry picked from commit c3643a1)

Co-authored-by: Kirill Podoprigora <[email protected]>
@bedevere-app

bedevere-app Bot commented May 9, 2024

Copy link
Copy Markdown

GH-118847 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 9, 2024
gvanrossum pushed a commit that referenced this pull request May 9, 2024
@miss-islington @Eclips4
[3.13] gh-118817: Fix asyncio REPL on Windows (GH-118819) (#118847)
738877a 
(cherry picked from commit c3643a1)

Co-authored-by: Kirill Podoprigora <[email protected]>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
@Eclips4 @SonicField
pythongh-118817: Fix asyncio REPL on Windows (python#118819)
ec921f7
@ambv ambv added the topic-repl Related to the interactive shell label May 23, 2024
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@sobolevn sobolevn sobolevn approved these changes
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Eclips4 @gvanrossum @sobolevn @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.