GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118849: Fix "code will never be executed" warning in `dictobject.c` by sobolevn · Pull Request #118850 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented May 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refs #115108

  • Issue: code will never be executed warning in dictobject.c #118849

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-118849: Fix "code will never be executed" warning in `dictob…
d02409a 
…ject.c`
@sobolevn sobolevn added skip news needs backport to 3.13 only security fixes labels May 9, 2024
@sobolevn
sobolevn requested a review from colesbury May 9, 2024 15:31
@sobolevn
sobolevn requested review from markshannon and methane as code owners May 9, 2024 15:31
@bedevere-app bedevere-app Bot added the awaiting core review label May 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 9, 2024
code will never be executed warning in dictobject.c #118849
Closed
colesbury
colesbury reviewed May 9, 2024
View reviewed changes
Comment thread Objects/dictobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Fix CI
6056023
colesbury
colesbury approved these changes May 9, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 9, 2024
@sobolevn
sobolevn merged commit 82abe75 into python:main May 9, 2024
@miss-islington-app

miss-islington-app Bot commented May 9, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 9, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
@sobolevn @miss-islington
pythongh-118849: Fix "code will never be executed" warning in `dictob…
9b2ac2e 
…ject.c` (pythonGH-118850)

(cherry picked from commit 82abe75)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app

bedevere-app Bot commented May 9, 2024

Copy link
Copy Markdown

GH-118859 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 9, 2024
@sobolevn

sobolevn commented May 9, 2024

Copy link
Copy Markdown
Member Author

Thanks for the good catch and for the review! :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn added a commit that referenced this pull request May 9, 2024
@miss-islington @sobolevn
[3.13] gh-118849: Fix "code will never be executed" warning in `dicto…
098eec9 
…bject.c` (GH-118850) (#118859)

gh-118849: Fix "code will never be executed" warning in `dictobject.c` (GH-118850)
(cherry picked from commit 82abe75)

Co-authored-by: Nikita Sobolev <[email protected]>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
@sobolevn @SonicField
pythongh-118849: Fix "code will never be executed" warning in `dictob…
63af4b5 
…ject.c` (python#118850)
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@methane methane Awaiting requested review from methane methane is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sobolevn @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.