GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118851: Default ctx arguments to AST constructors to Load() by JelleZijlstra · Pull Request #118854 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 9, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Default expr_context parameters in ast to Load() #118851

📚 Documentation preview 📚: https://cpython-previews--118854.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JelleZijlstra added 2 commits May 9, 2024 08:46
@JelleZijlstra
pythongh-118851: Default ctx arguments to AST constructors to Load()
83d76cd
@JelleZijlstra
tweaks
0389883
@JelleZijlstra
JelleZijlstra requested a review from AlexWaygood May 9, 2024 15:49
@JelleZijlstra
JelleZijlstra requested a review from isidentical as a code owner May 9, 2024 15:49
@bedevere-app bedevere-app Bot added the awaiting core review label May 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 9, 2024
Default expr_context parameters in ast to Load() #118851
Closed
@JelleZijlstra JelleZijlstra mentioned this pull request May 9, 2024
improvement: Add AST subclass constructors python/typeshed#11880
Merged
AlexWaygood
AlexWaygood approved these changes May 9, 2024
View reviewed changes
Comment thread Doc/library/ast.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 9, 2024
Eclips4
Eclips4 reviewed May 9, 2024
View reviewed changes
Comment thread Doc/library/ast.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra @AlexWaygood
Update Doc/library/ast.rst
b4d31e6 
Co-authored-by: Alex Waygood <[email protected]>
@JelleZijlstra JelleZijlstra added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 9, 2024
@bedevere-bot

bedevere-bot commented May 9, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit b4d31e6 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label May 9, 2024
@JelleZijlstra JelleZijlstra added the needs backport to 3.13 only security fixes label May 9, 2024
@JelleZijlstra

JelleZijlstra commented May 9, 2024

Copy link
Copy Markdown
Member Author

I think the remaining and failing buildbots are unrelated to this PR.

3:59:31 load avg: 15.60 running (1): test.test_concurrent_futures.test_deadlock (2 hour 39 min)

... I wonder if it has a deadlock.
AlexWaygood and Eclips4 reacted with laugh emoji
All reactions
  • 😄 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit 68fbc00 into python:main May 9, 2024
@miss-islington-app

miss-islington-app Bot commented May 9, 2024

Copy link
Copy Markdown

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 9, 2024
@JelleZijlstra
JelleZijlstra deleted the astload branch May 9, 2024 22:30
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
@JelleZijlstra @AlexWaygood @miss-islington
pythongh-118851: Default ctx arguments to AST constructors to Load() (p…
a316822 
…ythonGH-118854)

(cherry picked from commit 68fbc00)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@bedevere-app

bedevere-app Bot commented May 9, 2024

Copy link
Copy Markdown

GH-118871 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 9, 2024
JelleZijlstra added a commit that referenced this pull request May 9, 2024
@miss-islington @JelleZijlstra @AlexWaygood
[3.13] gh-118851: Default ctx arguments to AST constructors to Load() (…
00ec116 
…GH-118854) (#118871)

(cherry picked from commit 68fbc00)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
@JelleZijlstra @AlexWaygood @SonicField
pythongh-118851: Default ctx arguments to AST constructors to Load() (p…
bb8677d 
…ython#118854)

Co-authored-by: Alex Waygood <[email protected]>
@AlexWaygood AlexWaygood mentioned this pull request May 10, 2024
gh-118846: Fix free-threading test failures when run sequentially #118864
Merged
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 left review comments
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@isidentical isidentical Awaiting requested review from isidentical

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @bedevere-bot @AlexWaygood @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.