GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118846: Fix PGO tests in free-threaded build by colesbury · Pull Request #118862 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented May 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Avoid immortalizing objects in tests that verify garbage collection of classes or modules.

This fixes test_ordered_dict and test_struct.

  • Issue: Freethreading build fails -m test --pgo: test_ordered_dict and test_struct failed #118846

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-118846: Fix PGO tests in free-threaded build
f203ebf 
Avoid immortalizing objects in some tests that test behavior of
collecting classes or modules.

This fixes test_ordered_dict and test_struct.
@colesbury colesbury added tests Tests in the Lib/test dir skip news topic-free-threading needs backport to 3.13 only security fixes labels May 9, 2024
@colesbury
colesbury requested a review from DinoV May 9, 2024 18:28
@bedevere-app bedevere-app Bot added the awaiting core review label May 9, 2024
@bedevere-app bedevere-app Bot mentioned this pull request May 9, 2024
Freethreading build fails -m test --pgo: test_ordered_dict and test_struct failed #118846
Closed
@colesbury

colesbury commented May 9, 2024

Copy link
Copy Markdown
Contributor Author

cc @hroncok - I'll look at the other tests next, but this should be enough to fix the PGO build.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hroncok

hroncok commented May 9, 2024

Copy link
Copy Markdown
Contributor

but this should be enough to fix the PGO build.

Indeed it is. Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hroncok
hroncok approved these changes May 9, 2024
View reviewed changes
@colesbury colesbury mentioned this pull request May 9, 2024
gh-118846: Fix free-threading test failures when run sequentially #118864
Merged
DinoV
DinoV approved these changes May 9, 2024
View reviewed changes

@DinoV DinoV left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 9, 2024
@colesbury
colesbury merged commit 1b1db2f into python:main May 9, 2024
@miss-islington-app

miss-islington-app Bot commented May 9, 2024

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury deleted the gh-118846-pgo-tests branch May 9, 2024 20:06
@bedevere-app bedevere-app Bot removed the awaiting merge label May 9, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
@colesbury @miss-islington
pythongh-118846: Fix PGO tests in free-threaded build (pythonGH-118862)
89b8e85 
Avoid immortalizing objects in tests that verify garbage collection of
classes or modules.

This fixes test_ordered_dict and test_struct.
(cherry picked from commit 1b1db2f)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app

bedevere-app Bot commented May 9, 2024

Copy link
Copy Markdown

GH-118867 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 9, 2024
colesbury added a commit that referenced this pull request May 9, 2024
@miss-islington @colesbury
[3.13] gh-118846: Fix PGO tests in free-threaded build (GH-118862) (#…
d4c6948 
…118867)

Avoid immortalizing objects in tests that verify garbage collection of
classes or modules.

This fixes test_ordered_dict and test_struct.
(cherry picked from commit 1b1db2f)

Co-authored-by: Sam Gross <[email protected]>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
@colesbury @SonicField
pythongh-118846: Fix PGO tests in free-threaded build (python#118862)
888d3d7 
Avoid immortalizing objects in tests that verify garbage collection of
classes or modules.

This fixes test_ordered_dict and test_struct.
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DinoV DinoV DinoV approved these changes
+1 more reviewer
@hroncok hroncok hroncok approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@colesbury @hroncok @DinoV
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.