GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117657: Fix data races reported by TSAN on `interp->threads.main` by mpage · Pull Request #118865 · python/cpython

Conversation

@mpage

@mpage mpage commented May 9, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Use relaxed loads/stores when reading/writing to this field.

This fixes races like https://gist.github.com/mpage/e07497ad8dd444a789ff306cb7996acc

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mpage
Fix data races reported by TSAN on interp->threads.main
50cf12b 
Use relaxed loads/stores when reading/writing to this field.

This fixes races like https://gist.github.com/mpage/e07497ad8dd444a789ff306cb7996acc
@bedevere-app bedevere-app Bot mentioned this pull request May 9, 2024
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
@blurb-it
📜🤖 Added by blurb_it.
f412a0c
@mpage
mpage requested a review from colesbury May 9, 2024 20:24
@mpage
mpage marked this pull request as ready for review May 9, 2024 20:24
@mpage
mpage requested a review from ericsnowcurrently as a code owner May 9, 2024 20:24
@bedevere-app bedevere-app Bot added the awaiting review label May 9, 2024
colesbury
colesbury approved these changes May 9, 2024
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Can we remove any TSan suppressions after this change? I'm merging #118722 now, so you might want to wait a little bit and then merge main into this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mpage reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 9, 2024
@colesbury colesbury added the needs backport to 3.13 only security fixes label May 9, 2024
@mpage

mpage commented May 9, 2024

Copy link
Copy Markdown
Contributor Author

Sounds good. I'll wait until you merge #118722 then update this PR to remove the appropriate suppressions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mpage added 2 commits May 9, 2024 15:03
@mpage
Merge branch 'main' into pythongh-117657-tsan-is-running-main
7c9e286
@mpage
Remove corresponding suppressions
17d8622
@colesbury
colesbury merged commit 22d5185 into python:main May 10, 2024
@miss-islington-app

miss-islington-app Bot commented May 10, 2024

Copy link
Copy Markdown

Thanks @mpage for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 10, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2024
@mpage @miss-islington
pythongh-117657: Fix data races reported by TSAN on `interp->threads.…
6d5e97f 
…main` (pythonGH-118865)

Use relaxed loads/stores when reading/writing to this field.
(cherry picked from commit 22d5185)

Co-authored-by: mpage <[email protected]>
@bedevere-app

bedevere-app Bot commented May 10, 2024

Copy link
Copy Markdown

GH-118904 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 10, 2024
colesbury pushed a commit that referenced this pull request May 10, 2024
@miss-islington @mpage
[3.13] gh-117657: Fix data races reported by TSAN on `interp->threads…
4480dd8 
….main` (GH-118865) (#118904)

Use relaxed loads/stores when reading/writing to this field.
(cherry picked from commit 22d5185)

Co-authored-by: mpage <[email protected]>
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
backport a9a74da 3.13 #119642
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mpage @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.